* [PATCH] score: Kconfig: drop nine selects and one entry
@ 2011-11-12 22:18 Paul Bolle
2013-03-06 9:17 ` [PATCH] [RESEND] " Paul Bolle
0 siblings, 1 reply; 2+ messages in thread
From: Paul Bolle @ 2011-11-12 22:18 UTC (permalink / raw)
To: Chen Liqin, Lennox Wu; +Cc: linux-kernel
The config entries in the "System type" choice each use the same three
select statements. The Kconfig symbol SYS_SUPPORTS_32BIT_KERNEL is only
used by mips. The Kconfig symbol CPU_SCORE7 is used once, in an (almost)
empty Kconfig entry, and there are no uses of CONFIG_CPU_SCORE7. (This
means that the CPU_SCORE7 entry can also be dropped.) And
GENERIC_HAS_IOMAP is a typo. It should have been GENERIC_IOMAP. But
there's an entry for GENERIC_IOMAP that defaults to y, so no one
noticed.
So all selects from the config entries in this choice can be dropped.
And so can the CPU_SCORE7 config entry.
Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
---
0) git grep tested only.
1) Please note that ARCH_SCORE7, MACH_SPCT6600, and SCORE_SIM aren't
used anywhere else. There are also no uses of CONFIG_ARCH_SCORE7,
CONFIG_MACH_SPCT6600, and CONFIG_SCORE_SIM macros. Perhaps the entire
"System type" choice can be dropped.
arch/score/Kconfig | 13 +------------
1 files changed, 1 insertions(+), 12 deletions(-)
diff --git a/arch/score/Kconfig b/arch/score/Kconfig
index df169e8..4390afc 100644
--- a/arch/score/Kconfig
+++ b/arch/score/Kconfig
@@ -11,28 +11,17 @@ choice
config ARCH_SCORE7
bool "SCORE7 processor"
- select SYS_SUPPORTS_32BIT_KERNEL
- select CPU_SCORE7
- select GENERIC_HAS_IOMAP
config MACH_SPCT6600
bool "SPCT6600 series based machines"
- select SYS_SUPPORTS_32BIT_KERNEL
- select CPU_SCORE7
- select GENERIC_HAS_IOMAP
config SCORE_SIM
bool "Score simulator"
- select SYS_SUPPORTS_32BIT_KERNEL
- select CPU_SCORE7
- select GENERIC_HAS_IOMAP
+
endchoice
endmenu
-config CPU_SCORE7
- bool
-
config GENERIC_IOMAP
def_bool y
--
1.7.4.4
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH] [RESEND] score: Kconfig: drop nine selects and one entry
2011-11-12 22:18 [PATCH] score: Kconfig: drop nine selects and one entry Paul Bolle
@ 2013-03-06 9:17 ` Paul Bolle
0 siblings, 0 replies; 2+ messages in thread
From: Paul Bolle @ 2013-03-06 9:17 UTC (permalink / raw)
To: Chen Liqin, Lennox Wu; +Cc: linux-kernel
The config entries in the "System type" choice each use the same three
select statements. The Kconfig symbol SYS_SUPPORTS_32BIT_KERNEL is only
used by mips. The Kconfig symbol CPU_SCORE7 is used once, in an (almost)
empty Kconfig entry, and there are no uses of CONFIG_CPU_SCORE7. (This
means that the CPU_SCORE7 entry can also be dropped.) And
GENERIC_HAS_IOMAP is a typo. It should have been GENERIC_IOMAP. But
there's an entry for GENERIC_IOMAP that defaults to y, so no one
noticed.
So all selects from the config entries in this choice can be dropped.
And so can the CPU_SCORE7 config entry.
Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
---
0) This patch was first sent over a year ago. Now I have reapplied it on
top of v3.9-rc1, which required a trivial adaption to context changes.
1) Still git grep tested only.
2) Please note that ARCH_SCORE7, MACH_SPCT6600, and SCORE_SIM still
aren't used anywhere else. There are also no uses of CONFIG_ARCH_SCORE7,
CONFIG_MACH_SPCT6600, and CONFIG_SCORE_SIM macros. Perhaps the entire
"System type" choice can be dropped.
arch/score/Kconfig | 13 +------------
1 file changed, 1 insertion(+), 12 deletions(-)
diff --git a/arch/score/Kconfig b/arch/score/Kconfig
index e569aa1..382b996 100644
--- a/arch/score/Kconfig
+++ b/arch/score/Kconfig
@@ -22,28 +22,17 @@ choice
config ARCH_SCORE7
bool "SCORE7 processor"
- select SYS_SUPPORTS_32BIT_KERNEL
- select CPU_SCORE7
- select GENERIC_HAS_IOMAP
config MACH_SPCT6600
bool "SPCT6600 series based machines"
- select SYS_SUPPORTS_32BIT_KERNEL
- select CPU_SCORE7
- select GENERIC_HAS_IOMAP
config SCORE_SIM
bool "Score simulator"
- select SYS_SUPPORTS_32BIT_KERNEL
- select CPU_SCORE7
- select GENERIC_HAS_IOMAP
+
endchoice
endmenu
-config CPU_SCORE7
- bool
-
config NO_DMA
bool
default y
--
1.7.11.7
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-03-06 9:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-11-12 22:18 [PATCH] score: Kconfig: drop nine selects and one entry Paul Bolle
2013-03-06 9:17 ` [PATCH] [RESEND] " Paul Bolle
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®