* [PATCH] regmap: cache: Provide a get address of value operation
@ 2013-03-13 19:31 Mark Brown
0 siblings, 0 replies; only message in thread
From: Mark Brown @ 2013-03-13 19:31 UTC (permalink / raw)
To: linux-kernel; +Cc: Mark Brown
Provide a helper to do the size based index into a block of registers and
use it when reading a value.
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
---
drivers/base/regmap/internal.h | 6 ++++++
drivers/base/regmap/regcache.c | 4 ++--
2 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/drivers/base/regmap/internal.h b/drivers/base/regmap/internal.h
index 9fc351f0..54b2fd9 100644
--- a/drivers/base/regmap/internal.h
+++ b/drivers/base/regmap/internal.h
@@ -190,6 +190,12 @@ int regcache_write(struct regmap *map,
unsigned int reg, unsigned int value);
int regcache_sync(struct regmap *map);
+static inline void *regcache_get_val_addr(struct regmap *map, const void *base,
+ unsigned int idx)
+{
+ return base + (map->cache_word_size * idx);
+}
+
unsigned int regcache_get_val(struct regmap *map, const void *base,
unsigned int idx);
bool regcache_set_val(struct regmap *map, void *base, unsigned int idx,
diff --git a/drivers/base/regmap/regcache.c b/drivers/base/regmap/regcache.c
index 0f4fb8b..229c804 100644
--- a/drivers/base/regmap/regcache.c
+++ b/drivers/base/regmap/regcache.c
@@ -458,8 +458,8 @@ unsigned int regcache_get_val(struct regmap *map, const void *base,
/* Use device native format if possible */
if (map->format.parse_val)
- return map->format.parse_val(base +
- (map->cache_word_size * idx));
+ return map->format.parse_val(regcache_get_val_addr(map, base,
+ idx));
switch (map->cache_word_size) {
case 1: {
--
1.7.10.4
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2013-03-13 19:31 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-03-13 19:31 [PATCH] regmap: cache: Provide a get address of value operation Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®