* [PATCH] imx_drm: ipu_v3: fix invalid free of devm_* allocated data
@ 2013-03-16 12:02 Silviu-Mihai Popescu
2013-03-19 10:33 ` Sascha Hauer
0 siblings, 1 reply; 2+ messages in thread
From: Silviu-Mihai Popescu @ 2013-03-16 12:02 UTC (permalink / raw)
To: devel; +Cc: s.hauer, linux-kernel, Silviu-Mihai Popescu
The objects allocated by devm_* APIs are managed by devres and are freed
when the device is detached. There is no need to use kfree() explicitly.
Signed-off-by: Silviu-Mihai Popescu <silviupopescu1990@gmail.com>
---
drivers/staging/imx-drm/ipu-v3/ipu-dp.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/imx-drm/ipu-v3/ipu-dp.c b/drivers/staging/imx-drm/ipu-v3/ipu-dp.c
index 26aecaf..113b046 100644
--- a/drivers/staging/imx-drm/ipu-v3/ipu-dp.c
+++ b/drivers/staging/imx-drm/ipu-v3/ipu-dp.c
@@ -316,7 +316,6 @@ int ipu_dp_init(struct ipu_soc *ipu, struct device *dev, unsigned long base)
priv->base = devm_ioremap(dev, base, PAGE_SIZE);
if (!priv->base) {
- kfree(priv);
return -ENOMEM;
}
--
1.7.9.5
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] imx_drm: ipu_v3: fix invalid free of devm_* allocated data
2013-03-16 12:02 [PATCH] imx_drm: ipu_v3: fix invalid free of devm_* allocated data Silviu-Mihai Popescu
@ 2013-03-19 10:33 ` Sascha Hauer
0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2013-03-19 10:33 UTC (permalink / raw)
To: Silviu-Mihai Popescu; +Cc: devel, linux-kernel
On Sat, Mar 16, 2013 at 02:02:36PM +0200, Silviu-Mihai Popescu wrote:
> The objects allocated by devm_* APIs are managed by devres and are freed
> when the device is detached. There is no need to use kfree() explicitly.
Not only 'no need', it's simply wrong.
>
> Signed-off-by: Silviu-Mihai Popescu <silviupopescu1990@gmail.com>
Acked-by: Sascha Hauer <s.hauer@pengutronix.de>
Sascha
> ---
> drivers/staging/imx-drm/ipu-v3/ipu-dp.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/imx-drm/ipu-v3/ipu-dp.c b/drivers/staging/imx-drm/ipu-v3/ipu-dp.c
> index 26aecaf..113b046 100644
> --- a/drivers/staging/imx-drm/ipu-v3/ipu-dp.c
> +++ b/drivers/staging/imx-drm/ipu-v3/ipu-dp.c
> @@ -316,7 +316,6 @@ int ipu_dp_init(struct ipu_soc *ipu, struct device *dev, unsigned long base)
>
> priv->base = devm_ioremap(dev, base, PAGE_SIZE);
> if (!priv->base) {
> - kfree(priv);
> return -ENOMEM;
> }
>
> --
> 1.7.9.5
>
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-03-19 10:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-03-16 12:02 [PATCH] imx_drm: ipu_v3: fix invalid free of devm_* allocated data Silviu-Mihai Popescu
2013-03-19 10:33 ` Sascha Hauer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®