mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
	Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.de>,
	alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sound: max98090: Remove executable bit
Date: Wed, 20 Mar 2013 15:54:32 -0700	[thread overview]
Message-ID: <1363820072.16270.43.camel@joe-AO722> (raw)
In-Reply-To: <20130320163627.GS28775@opensource.wolfsonmicro.com>

On Wed, 2013-03-20 at 17:36 +0100, Mark Brown wrote:
> On Wed, Mar 20, 2013 at 08:22:16AM -0700, Joe Perches wrote:
> > On Wed, 2013-03-20 at 10:57 +0100, Mark Brown wrote:
> 
> > > I've applied this but I'm fed up to the back teeth of having to hand
> > > edit trivial patches from you because you ignore the subject line styles
> > > of subsystems and make up your own.
> 
> > Your style rules just don't matter to me and
> > you can ignore the patches and fix it yourself.
> 
> > Or better, create a tool for others to use that
> > follow your silly style rules.
> 
> This is just like any other coding style thing - you should be creating
> patches that look like other patches for the affected, if there's things
> like obvious visual differences in what you're doing you're doing it
> wrong.

We've had this conversation before and I proposed
to you a simple solution.
https://lkml.org/lkml/2010/11/16/245
and I still more or less agree with Florian
https://lkml.org/lkml/2010/11/16/314

I'm not doing it wrong.  You have another demand
others don't.  I simply don't find it necessary to
cater to you.

If you want it to be agreed that there is a specific
form for subject headers that varies by maintainer tree,
change SubmittingPatches Paragraph 11.

> Automation doesn't work for things like this, there's a good solid
> reason why there's generally a human involved in patch; the other people
> who submit lots of cleanups generally manage to figure this out
> usefully, you might want to discuss techniques with them.

I suggest you use a git pre-commit hook to your
tree and use sed/perl to add a specific prefix
if it doesn't exist.
http://codeinthehole.com/writing/tips-for-using-a-git-pre-commit-hook/



  parent reply	other threads:[~2013-03-20 22:54 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-19 21:58 Joe Perches
     [not found] ` <20130320095758.GD28775@opensource.wolfsonmicro.com>
2013-03-20 15:22   ` Joe Perches
     [not found]     ` <20130320163627.GS28775@opensource.wolfsonmicro.com>
2013-03-20 22:54       ` Joe Perches [this message]
     [not found]         ` <20130321162503.GC14768@opensource.wolfsonmicro.com>
2013-03-21 17:16           ` Joe Perches
2013-03-21 17:44             ` Mark Brown
2013-03-21 17:53               ` Joe Perches
2013-03-21 18:44                 ` Mark Brown
2013-03-21 19:16                   ` Joe Perches
2013-03-21 20:37                     ` Mark Brown
2013-03-21 20:40                       ` Joe Perches
2013-03-21 21:26                         ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1363820072.16270.43.camel@joe-AO722 \
    --to=joe@perches.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®