From: Joe Perches <joe@perches.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.de>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sound: max98090: Remove executable bit
Date: Thu, 21 Mar 2013 12:16:45 -0700 [thread overview]
Message-ID: <1363893405.30275.39.camel@joe-AO722> (raw)
In-Reply-To: <20130321184458.GH15926@opensource.wolfsonmicro.com>
On Thu, 2013-03-21 at 19:44 +0100, Mark Brown wrote:
> On Thu, Mar 21, 2013 at 10:53:13AM -0700, Joe Perches wrote:
> > On Thu, 2013-03-21 at 18:44 +0100, Mark Brown wrote:
>
> > > That one needs a bit more taste and thought to work out what's
> > > appropraite than can be guaranteed easily with a script, things like
> > > working out drive level prefixes for example.
>
> > [perfectly useful git applypatch-msg hook script removed]
>
> No, it really isn't. Have you tried looking at the output? It's not
> going to do the right thing for the subject line here for example, never
> mind any other cases.
Define "the right thing" for this instance.
The commit isn't in -next so I have no idea what
you actually applied. (nor do I really care btw)
Did you try it?
It commits:
ASoC: sound: max98080: Remove executable bit
If you're really anal about it and you want
sound: for sound/soc removed,
perl -p -i -e 's/^(?:ASoC:\s*)?(?:sound:\s*)?(.*)$/ASoC: $1/g if 1 .. 1' ${1+"$@"}
This is a "your taste" issue only, and do keep in mind
mountains vs molehills.
cheers, Joe
next prev parent reply other threads:[~2013-03-21 19:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-19 21:58 Joe Perches
[not found] ` <20130320095758.GD28775@opensource.wolfsonmicro.com>
2013-03-20 15:22 ` Joe Perches
[not found] ` <20130320163627.GS28775@opensource.wolfsonmicro.com>
2013-03-20 22:54 ` Joe Perches
[not found] ` <20130321162503.GC14768@opensource.wolfsonmicro.com>
2013-03-21 17:16 ` Joe Perches
2013-03-21 17:44 ` Mark Brown
2013-03-21 17:53 ` Joe Perches
2013-03-21 18:44 ` Mark Brown
2013-03-21 19:16 ` Joe Perches [this message]
2013-03-21 20:37 ` Mark Brown
2013-03-21 20:40 ` Joe Perches
2013-03-21 21:26 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1363893405.30275.39.camel@joe-AO722 \
--to=joe@perches.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®