From: Tomas Winkler <tomas.winkler@intel.com>
To: gregkh@linuxfoundation.org
Cc: arnd@arndb.de, linux-kernel@vger.kernel.org,
Samuel Ortiz <sameo@linux.intel.com>,
Tomas Winkler <tomas.winkler@intel.com>
Subject: [char-misc-next 10/11 V5] mei: nfc: Add NFC device to the MEI bus
Date: Wed, 27 Mar 2013 17:30:02 +0200 [thread overview]
Message-ID: <1364398203-11159-11-git-send-email-tomas.winkler@intel.com> (raw)
In-Reply-To: <1364398203-11159-1-git-send-email-tomas.winkler@intel.com>
From: Samuel Ortiz <sameo@linux.intel.com>
After building its bus name as a string based on its vendor id and radio
type, we can add it to the bus.
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
---
drivers/misc/mei/nfc.c | 55 ++++++++++++++++++++++++++++++++++++++++++++++++++
drivers/misc/mei/nfc.h | 6 ++++++
2 files changed, 61 insertions(+)
diff --git a/drivers/misc/mei/nfc.c b/drivers/misc/mei/nfc.c
index b903d82..372d336 100644
--- a/drivers/misc/mei/nfc.c
+++ b/drivers/misc/mei/nfc.c
@@ -42,6 +42,8 @@ struct mei_nfc_dev {
u8 fw_ivn;
u8 vendor_id;
u8 radio_type;
+
+ char *bus_name;
};
static struct mei_nfc_dev nfc_dev;
@@ -70,6 +72,39 @@ static void mei_nfc_free(struct mei_nfc_dev *ndev)
}
}
+static int mei_nfc_build_bus_name(struct mei_nfc_dev *ndev)
+{
+ struct mei_device *dev;
+
+ if (!ndev->cl)
+ return -ENODEV;
+
+ dev = ndev->cl->dev;
+
+ switch (ndev->vendor_id) {
+ case MEI_NFC_VENDOR_INSIDE:
+ switch (ndev->radio_type) {
+ case MEI_NFC_VENDOR_INSIDE_UREAD:
+ ndev->bus_name = "microread";
+ return 0;
+
+ default:
+ dev_err(&dev->pdev->dev, "Unknow radio type 0x%x\n",
+ ndev->radio_type);
+
+ return -EINVAL;
+ }
+
+ default:
+ dev_err(&dev->pdev->dev, "Unknow vendor ID 0x%x\n",
+ ndev->vendor_id);
+
+ return -EINVAL;
+ }
+
+ return 0;
+}
+
static int mei_nfc_connect(struct mei_nfc_dev *ndev)
{
struct mei_device *dev;
@@ -191,6 +226,7 @@ err:
static void mei_nfc_init(struct work_struct *work)
{
struct mei_device *dev;
+ struct mei_cl_device *cldev;
struct mei_nfc_dev *ndev;
struct mei_cl *cl_info, *cl;
int ret;
@@ -242,6 +278,22 @@ static void mei_nfc_init(struct work_struct *work)
return;
}
+ if (mei_nfc_build_bus_name(ndev) < 0) {
+ dev_err(&dev->pdev->dev,
+ "Could not build the bus ID name\n");
+ return;
+ }
+
+ cldev = mei_cl_add_device(dev, mei_nfc_guid, ndev->bus_name);
+ if (!cldev) {
+ dev_err(&dev->pdev->dev,
+ "Could not add the NFC device to the MEI bus\n");
+
+ goto err;
+ }
+
+ cldev->priv_data = ndev;
+
return;
err:
@@ -323,5 +375,8 @@ void mei_nfc_host_exit(void)
{
struct mei_nfc_dev *ndev = &nfc_dev;
+ if (ndev->cl && ndev->cl->device)
+ mei_cl_remove_device(ndev->cl->device);
+
mei_nfc_free(ndev);
}
diff --git a/drivers/misc/mei/nfc.h b/drivers/misc/mei/nfc.h
index 59e6703..4440436 100644
--- a/drivers/misc/mei/nfc.h
+++ b/drivers/misc/mei/nfc.h
@@ -119,4 +119,10 @@ struct mei_nfc_connect_resp {
#define MEI_NFC_SUBCMD_CONNECT 0x00
#define MEI_NFC_SUBCMD_IF_VERSION 0x01
+/* Vendors */
+#define MEI_NFC_VENDOR_INSIDE 0x00
+
+/* Radio types */
+#define MEI_NFC_VENDOR_INSIDE_UREAD 0x00
+
#endif /* _MEI_NFC_H */
--
1.7.11.7
next prev parent reply other threads:[~2013-03-27 15:32 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-27 15:29 [char-misc-next 00/11 V5] Add Client MEI bus and NFC device Tomas Winkler
2013-03-27 15:29 ` [char-misc-next 01/11 V5] mei: bus: Initial MEI Client bus type implementation Tomas Winkler
2013-03-27 15:29 ` [char-misc-next 02/11 V5] mei: bus: Implement driver registration Tomas Winkler
2013-03-27 15:29 ` [char-misc-next 03/11 V5] mei: bus: Initial implementation for I/O routines Tomas Winkler
2013-03-27 15:29 ` [char-misc-next 04/11 V5] mei: bus: Add bus related structures to mei_cl Tomas Winkler
2013-03-27 15:29 ` [char-misc-next 05/11 V5] mei: bus: Call bus routines from the core code Tomas Winkler
2013-03-27 15:29 ` [char-misc-next 06/11 V5] mei: bus: Synchronous API for the data transmission Tomas Winkler
2013-03-27 15:29 ` [char-misc-next 07/11 V5] mei: bus: Implement bus driver data setter/getter Tomas Winkler
2013-03-27 15:30 ` [char-misc-next 08/11 V5] mei: nfc: Initial nfc implementation Tomas Winkler
2013-03-29 15:48 ` Greg KH
2013-03-31 22:49 ` Samuel Ortiz
2013-03-31 23:04 ` Greg KH
2013-03-29 15:49 ` Greg KH
2013-03-27 15:30 ` [char-misc-next 09/11 V5] mei: nfc: Connect also the regular ME client Tomas Winkler
2013-03-27 15:30 ` Tomas Winkler [this message]
2013-03-27 15:30 ` [char-misc-next 11/11 V5] mei: nfc: Implement MEI bus IO ops Tomas Winkler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1364398203-11159-11-git-send-email-tomas.winkler@intel.com \
--to=tomas.winkler@intel.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome