From: Tomas Winkler <tomas.winkler@intel.com>
To: gregkh@linuxfoundation.org
Cc: arnd@arndb.de, linux-kernel@vger.kernel.org,
Samuel Ortiz <sameo@linux.intel.com>,
Tomas Winkler <tomas.winkler@intel.com>
Subject: [char-misc-next 06/11 V5] mei: bus: Synchronous API for the data transmission
Date: Wed, 27 Mar 2013 17:29:58 +0200 [thread overview]
Message-ID: <1364398203-11159-7-git-send-email-tomas.winkler@intel.com> (raw)
In-Reply-To: <1364398203-11159-1-git-send-email-tomas.winkler@intel.com>
From: Samuel Ortiz <sameo@linux.intel.com>
Define a truly synchronous API for the bus Tx path by putting all pending
request to the write list and wait for the interrupt tx handler to wake
us up.
The ___mei_cl_send() out path is also slightly reworked to make it look more
like main.c:mei_write().
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
---
drivers/misc/mei/bus.c | 39 +++++++++++++++++++++++++++++----------
drivers/misc/mei/mei_dev.h | 1 +
2 files changed, 30 insertions(+), 10 deletions(-)
diff --git a/drivers/misc/mei/bus.c b/drivers/misc/mei/bus.c
index c626dc9..2b4b5b3 100644
--- a/drivers/misc/mei/bus.c
+++ b/drivers/misc/mei/bus.c
@@ -222,7 +222,8 @@ void mei_cl_driver_unregister(struct mei_cl_driver *driver)
}
EXPORT_SYMBOL_GPL(mei_cl_driver_unregister);
-int __mei_cl_send(struct mei_cl *cl, u8 *buf, size_t length)
+static int ___mei_cl_send(struct mei_cl *cl, u8 *buf, size_t length,
+ bool blocking)
{
struct mei_device *dev;
struct mei_msg_hdr mei_hdr;
@@ -273,11 +274,8 @@ int __mei_cl_send(struct mei_cl *cl, u8 *buf, size_t length)
cb->buf_idx = 0;
mei_hdr.msg_complete = 0;
cl->writing_state = MEI_WRITING;
- list_add_tail(&cb->list, &dev->write_list.list);
-
- mutex_unlock(&dev->device_lock);
- return length;
+ goto out;
}
dev->hbuf_is_ready = false;
@@ -303,19 +301,30 @@ int __mei_cl_send(struct mei_cl *cl, u8 *buf, size_t length)
cl->writing_state = MEI_WRITING;
cb->buf_idx = mei_hdr.length;
- if (!mei_hdr.msg_complete) {
- list_add_tail(&cb->list, &dev->write_list.list);
- } else {
+out:
+ if (mei_hdr.msg_complete) {
if (mei_cl_flow_ctrl_reduce(cl)) {
- err = -EIO;
+ err = -ENODEV;
goto out_err;
}
-
list_add_tail(&cb->list, &dev->write_waiting_list.list);
+ } else {
+ list_add_tail(&cb->list, &dev->write_list.list);
}
mutex_unlock(&dev->device_lock);
+ if (blocking && cl->writing_state != MEI_WRITE_COMPLETE) {
+ if (wait_event_interruptible(cl->tx_wait,
+ cl->writing_state == MEI_WRITE_COMPLETE)) {
+ if (signal_pending(current))
+ err = -EINTR;
+ err = -ERESTARTSYS;
+ mutex_lock(&dev->device_lock);
+ goto out_err;
+ }
+ }
+
return mei_hdr.length;
out_err:
@@ -382,6 +391,16 @@ out:
return r_length;
}
+inline int __mei_cl_async_send(struct mei_cl *cl, u8 *buf, size_t length)
+{
+ return ___mei_cl_send(cl, buf, length, 0);
+}
+
+inline int __mei_cl_send(struct mei_cl *cl, u8 *buf, size_t length)
+{
+ return ___mei_cl_send(cl, buf, length, 1);
+}
+
int mei_cl_send(struct mei_cl_device *device, u8 *buf, size_t length)
{
struct mei_cl *cl = device->cl;
diff --git a/drivers/misc/mei/mei_dev.h b/drivers/misc/mei/mei_dev.h
index 7d594be..325f71a 100644
--- a/drivers/misc/mei/mei_dev.h
+++ b/drivers/misc/mei/mei_dev.h
@@ -273,6 +273,7 @@ struct mei_cl_device *mei_cl_add_device(struct mei_device *dev,
uuid_le uuid, char *name);
void mei_cl_remove_device(struct mei_cl_device *device);
+int __mei_cl_async_send(struct mei_cl *cl, u8 *buf, size_t length);
int __mei_cl_send(struct mei_cl *cl, u8 *buf, size_t length);
int __mei_cl_recv(struct mei_cl *cl, u8 *buf, size_t length);
--
1.7.11.7
next prev parent reply other threads:[~2013-03-27 15:31 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-27 15:29 [char-misc-next 00/11 V5] Add Client MEI bus and NFC device Tomas Winkler
2013-03-27 15:29 ` [char-misc-next 01/11 V5] mei: bus: Initial MEI Client bus type implementation Tomas Winkler
2013-03-27 15:29 ` [char-misc-next 02/11 V5] mei: bus: Implement driver registration Tomas Winkler
2013-03-27 15:29 ` [char-misc-next 03/11 V5] mei: bus: Initial implementation for I/O routines Tomas Winkler
2013-03-27 15:29 ` [char-misc-next 04/11 V5] mei: bus: Add bus related structures to mei_cl Tomas Winkler
2013-03-27 15:29 ` [char-misc-next 05/11 V5] mei: bus: Call bus routines from the core code Tomas Winkler
2013-03-27 15:29 ` Tomas Winkler [this message]
2013-03-27 15:29 ` [char-misc-next 07/11 V5] mei: bus: Implement bus driver data setter/getter Tomas Winkler
2013-03-27 15:30 ` [char-misc-next 08/11 V5] mei: nfc: Initial nfc implementation Tomas Winkler
2013-03-29 15:48 ` Greg KH
2013-03-31 22:49 ` Samuel Ortiz
2013-03-31 23:04 ` Greg KH
2013-03-29 15:49 ` Greg KH
2013-03-27 15:30 ` [char-misc-next 09/11 V5] mei: nfc: Connect also the regular ME client Tomas Winkler
2013-03-27 15:30 ` [char-misc-next 10/11 V5] mei: nfc: Add NFC device to the MEI bus Tomas Winkler
2013-03-27 15:30 ` [char-misc-next 11/11 V5] mei: nfc: Implement MEI bus IO ops Tomas Winkler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1364398203-11159-7-git-send-email-tomas.winkler@intel.com \
--to=tomas.winkler@intel.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome