mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jean Delvare <jdelvare@suse.de>
To: linux-kernel <linux-kernel@vger.kernel.org>,
	Marek Vasut <marek.vasut@gmail.com>
Cc: Grant Likely <grant.likely@secretlab.ca>,
	Linus Walleij <linus.walleij@linaro.org>
Subject: gpio-ucb1400
Date: Fri, 29 Mar 2013 20:46:39 +0100	[thread overview]
Message-ID: <1364586399.4216.312.camel@amber.site> (raw)

Hi all,

In September 2009, a driver for the GPIO function of the UCB1400 chip
was added to the kernel tree. The probe function of this driver requires
ucbdata to be set. The only place where this happens is in function
ucb1400_gpio_set_data(). This function was never call, and still isn't.
So this is dead code for 3.5 years as far as the upstream kernel is
concerned.

To make things worse, this driver can't be built as a module, for no
good reason that I can see.

Marek, can you explain what was the point of submitting this driver that
nobody can use?

I would like either this driver to be fixed so that it can be used (and
that would IMHO start with dropping the ugly ucb1400_gpio_set_data hook
and global variable ucbdata), or this driver to be dropped from the
kernel tree. If the driver is kept, it should be adjusted so that it can
be built as a module.

If I overlooked something, please let me know.

Thanks,
-- 
Jean Delvare
Suse L3


             reply	other threads:[~2013-03-29 19:46 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-29 19:46 Jean Delvare [this message]
2013-03-30 15:10 ` gpio-ucb1400 Guenter Roeck
2013-03-30 19:20   ` gpio-ucb1400 Marek Vasut
2013-03-30 23:25     ` gpio-ucb1400 Guenter Roeck
2013-03-31 17:19       ` gpio-ucb1400 Marek Vasut
2013-04-01 11:06         ` gpio-ucb1400 Jean Delvare
2013-04-01 15:32           ` gpio-ucb1400 Mark Brown
2013-04-02  7:22             ` gpio-ucb1400 Jean Delvare
2013-04-02  8:45               ` gpio-ucb1400 Mark Brown
2013-04-10 18:18               ` gpio-ucb1400 Linus Walleij
2013-04-14 18:35                 ` [PATCH v2] UCB1400: Pass ucb1400-gpio data through ac97 bus Marek Vasut
2013-04-14 18:40                   ` Marek Vasut
2013-04-15 11:15                   ` Mark Brown
2013-04-17 15:24                   ` Linus Walleij
2013-04-18 22:40                   ` Samuel Ortiz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1364586399.4216.312.camel@amber.site \
    --to=jdelvare@suse.de \
    --cc=grant.likely@secretlab.ca \
    --cc=linus.walleij@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marek.vasut@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®