From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Jean Delvare <jdelvare@suse.de>
Cc: Marek Vasut <marek.vasut@gmail.com>,
Guenter Roeck <linux@roeck-us.net>,
linux-kernel <linux-kernel@vger.kernel.org>,
Grant Likely <grant.likely@secretlab.ca>,
Linus Walleij <linus.walleij@linaro.org>
Subject: Re: gpio-ucb1400
Date: Mon, 1 Apr 2013 16:32:47 +0100 [thread overview]
Message-ID: <20130401153247.GA13517@sirena.org.uk> (raw)
In-Reply-To: <1364814403.4943.7.camel@amber.site>
On Mon, Apr 01, 2013 at 01:06:43PM +0200, Jean Delvare wrote:
> My point was, the upstream gpio-ucb1400 driver in its current form is
> unusable (on top of being ugly.) I have no doubt that someone used that
> driver successfully in some external kernel tree, but the code that was
> merged upstream is incomplete and no good.
What the driver is doing is, unfortunately, the best practice for an
AC'97 connected device like this - we've got an uncomfortable mix of
an enumerable bus and platform data combined with a subsystem which has
never had enough love to work in a nice way with the kernel. The idea
is that any boards which have the device will call the _set_data()
function in their board-specific code.
Sadly we're a little short on volunteers to clean up the AC'97
subsystem so this situation shows little sign of improving.
next prev parent reply other threads:[~2013-04-01 15:32 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-29 19:46 gpio-ucb1400 Jean Delvare
2013-03-30 15:10 ` gpio-ucb1400 Guenter Roeck
2013-03-30 19:20 ` gpio-ucb1400 Marek Vasut
2013-03-30 23:25 ` gpio-ucb1400 Guenter Roeck
2013-03-31 17:19 ` gpio-ucb1400 Marek Vasut
2013-04-01 11:06 ` gpio-ucb1400 Jean Delvare
2013-04-01 15:32 ` Mark Brown [this message]
2013-04-02 7:22 ` gpio-ucb1400 Jean Delvare
2013-04-02 8:45 ` gpio-ucb1400 Mark Brown
2013-04-10 18:18 ` gpio-ucb1400 Linus Walleij
2013-04-14 18:35 ` [PATCH v2] UCB1400: Pass ucb1400-gpio data through ac97 bus Marek Vasut
2013-04-14 18:40 ` Marek Vasut
2013-04-15 11:15 ` Mark Brown
2013-04-17 15:24 ` Linus Walleij
2013-04-18 22:40 ` Samuel Ortiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130401153247.GA13517@sirena.org.uk \
--to=broonie@opensource.wolfsonmicro.com \
--cc=grant.likely@secretlab.ca \
--cc=jdelvare@suse.de \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=marek.vasut@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®