mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alex Shi <alex.shi@intel.com>
To: mingo@redhat.com, peterz@infradead.org, tglx@linutronix.de,
	akpm@linux-foundation.org, arjan@linux.intel.com, bp@alien8.de,
	pjt@google.com, namhyung@kernel.org, efault@gmx.de
Cc: vincent.guittot@linaro.org, gregkh@linuxfoundation.org,
	preeti@linux.vnet.ibm.com, viresh.kumar@linaro.org,
	linux-kernel@vger.kernel.org, alex.shi@intel.com
Subject: [patch v6 12/21] sched: add power aware scheduling in fork/exec/wake
Date: Sat, 30 Mar 2013 22:34:59 +0800	[thread overview]
Message-ID: <1364654108-16307-13-git-send-email-alex.shi@intel.com> (raw)
In-Reply-To: <1364654108-16307-1-git-send-email-alex.shi@intel.com>

This patch add power aware scheduling in fork/exec/wake. It try to
select cpu from the busiest while still has utilization group. That's
will save power since it leaves more groups idle in system.

The trade off is adding a power aware statistics collection in group
seeking. But since the collection just happened in power scheduling
eligible condition, the worst case of hackbench testing just drops
about 2% with powersaving policy. No clear change for performance
policy.

The main function in this patch is get_cpu_for_power_policy(), that
will try to get a idlest cpu from the busiest while still has
utilization group, if the system is using power aware policy and
has such group.

Signed-off-by: Alex Shi <alex.shi@intel.com>
---
 kernel/sched/fair.c | 109 +++++++++++++++++++++++++++++++++++++++++++++++++---
 1 file changed, 103 insertions(+), 6 deletions(-)

diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index 8ac021f..83b2c39 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -3368,25 +3368,113 @@ static unsigned int max_rq_util(int cpu)
 }
 
 /*
- * sched_balance_self: balance the current task (running on cpu) in domains
+ * Try to collect the task running number and capacity of the group.
+ */
+static void get_sg_power_stats(struct sched_group *group,
+	struct sched_domain *sd, struct sg_lb_stats *sgs)
+{
+	int i;
+
+	for_each_cpu(i, sched_group_cpus(group))
+		sgs->group_util += max_rq_util(i);
+
+	sgs->group_weight = group->group_weight;
+}
+
+/*
+ * Is this domain full of utilization with the task?
+ */
+static int is_sd_full(struct sched_domain *sd,
+		struct task_struct *p, struct sd_lb_stats *sds)
+{
+	struct sched_group *group;
+	struct sg_lb_stats sgs;
+	long sd_min_delta = LONG_MAX;
+	unsigned int putil;
+
+	if (p->se.load.weight == p->se.avg.load_avg_contrib)
+		/* p maybe a new forked task */
+		putil = FULL_UTIL;
+	else
+		putil = (u64)(p->se.avg.runnable_avg_sum << SCHED_POWER_SHIFT)
+				/ (p->se.avg.runnable_avg_period + 1);
+
+	/* Try to collect the domain's utilization */
+	group = sd->groups;
+	do {
+		long g_delta;
+
+		memset(&sgs, 0, sizeof(sgs));
+		get_sg_power_stats(group, sd, &sgs);
+
+		g_delta = sgs.group_weight * FULL_UTIL - sgs.group_util;
+
+		if (g_delta > 0 && g_delta < sd_min_delta) {
+			sd_min_delta = g_delta;
+			sds->group_leader = group;
+		}
+
+		sds->sd_util += sgs.group_util;
+	} while  (group = group->next, group != sd->groups);
+
+	if (sds->sd_util + putil < sd->span_weight * FULL_UTIL)
+		return 0;
+
+	/* can not hold one more task in this domain */
+	return 1;
+}
+
+/*
+ * Execute power policy if this domain is not full.
+ */
+static inline int get_sd_sched_balance_policy(struct sched_domain *sd,
+	int cpu, struct task_struct *p, struct sd_lb_stats *sds)
+{
+	if (sched_balance_policy == SCHED_POLICY_PERFORMANCE)
+		return SCHED_POLICY_PERFORMANCE;
+
+	memset(sds, 0, sizeof(*sds));
+	if (is_sd_full(sd, p, sds))
+		return SCHED_POLICY_PERFORMANCE;
+	return sched_balance_policy;
+}
+
+/*
+ * If power policy is eligible for this domain, and it has task allowed cpu.
+ * we will select CPU from this domain.
+ */
+static int get_cpu_for_power_policy(struct sched_domain *sd, int cpu,
+		struct task_struct *p, struct sd_lb_stats *sds)
+{
+	int policy;
+	int new_cpu = -1;
+
+	policy = get_sd_sched_balance_policy(sd, cpu, p, sds);
+	if (policy != SCHED_POLICY_PERFORMANCE && sds->group_leader)
+		new_cpu = find_idlest_cpu(sds->group_leader, p, cpu);
+
+	return new_cpu;
+}
+
+/*
+ * select_task_rq_fair: balance the current task (running on cpu) in domains
  * that have the 'flag' flag set. In practice, this is SD_BALANCE_FORK and
  * SD_BALANCE_EXEC.
  *
- * Balance, ie. select the least loaded group.
- *
  * Returns the target CPU number, or the same CPU if no balancing is needed.
  *
  * preempt must be disabled.
  */
 static int
-select_task_rq_fair(struct task_struct *p, int sd_flag, int wake_flags)
+select_task_rq_fair(struct task_struct *p, int sd_flag, int flags)
 {
 	struct sched_domain *tmp, *affine_sd = NULL, *sd = NULL;
 	int cpu = smp_processor_id();
 	int prev_cpu = task_cpu(p);
 	int new_cpu = cpu;
 	int want_affine = 0;
-	int sync = wake_flags & WF_SYNC;
+	int sync = flags & WF_SYNC;
+	struct sd_lb_stats sds;
 
 	if (p->nr_cpus_allowed == 1)
 		return prev_cpu;
@@ -3412,11 +3500,20 @@ select_task_rq_fair(struct task_struct *p, int sd_flag, int wake_flags)
 			break;
 		}
 
-		if (tmp->flags & sd_flag)
+		if (tmp->flags & sd_flag) {
 			sd = tmp;
+
+			new_cpu = get_cpu_for_power_policy(sd, cpu, p, &sds);
+			if (new_cpu != -1)
+				goto unlock;
+		}
 	}
 
 	if (affine_sd) {
+		new_cpu = get_cpu_for_power_policy(affine_sd, cpu, p, &sds);
+		if (new_cpu != -1)
+			goto unlock;
+
 		if (cpu != prev_cpu && wake_affine(affine_sd, p, sync))
 			prev_cpu = cpu;
 
-- 
1.7.12


  parent reply	other threads:[~2013-03-30 14:38 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-30 14:34 [patch v6 0/21] sched: power aware scheduling Alex Shi
2013-03-30 14:34 ` [patch v6 01/21] Revert "sched: Introduce temporary FAIR_GROUP_SCHED dependency for load-tracking" Alex Shi
2013-03-30 14:34 ` [patch v6 02/21] sched: set initial value of runnable avg for new forked task Alex Shi
2013-03-30 14:34 ` [patch v6 03/21] sched: only count runnable avg on cfs_rq's nr_running Alex Shi
2013-04-02 14:30   ` Vincent Guittot
2013-04-03  1:02     ` Alex Shi
2013-04-03  1:23       ` Paul Turner
2013-04-03  2:12         ` Alex Shi
2013-03-30 14:34 ` [patch v6 04/21] sched: add sched balance policies in kernel Alex Shi
2013-03-30 14:34 ` [patch v6 05/21] sched: add sysfs interface for sched_balance_policy selection Alex Shi
2013-03-30 14:34 ` [patch v6 06/21] sched: log the cpu utilization at rq Alex Shi
2013-03-30 14:34 ` [patch v6 07/21] sched: add new sg/sd_lb_stats fields for incoming fork/exec/wake balancing Alex Shi
2013-03-30 14:34 ` [patch v6 08/21] sched: move sg/sd_lb_stats struct ahead Alex Shi
2013-03-30 14:34 ` [patch v6 09/21] sched: scale_rt_power rename and meaning change Alex Shi
2013-03-30 14:34 ` [patch v6 10/21] sched: get rq potential maximum utilization Alex Shi
2013-04-02  9:02   ` Namhyung Kim
2013-04-02 13:38     ` Alex Shi
2013-04-03  2:15     ` Alex Shi
2013-04-03  2:22       ` Paul Turner
2013-04-03  2:35         ` Alex Shi
2013-04-03  8:07         ` Alex Shi
2013-04-02 14:38   ` Vincent Guittot
2013-04-03  1:11     ` Alex Shi
2013-03-30 14:34 ` [patch v6 11/21] sched: detect wakeup burst with rq->avg_idle Alex Shi
2013-04-03  8:12   ` Alex Shi
2013-03-30 14:34 ` Alex Shi [this message]
2013-04-01  9:50   ` [patch v6 12/21] sched: add power aware scheduling in fork/exec/wake Preeti U Murthy
2013-04-01 13:43     ` Alex Shi
2013-03-30 14:35 ` [patch v6 13/21] sched: using avg_idle to detect bursty wakeup Alex Shi
2013-04-03  5:08   ` Namhyung Kim
2013-04-03  5:41     ` Alex Shi
2013-04-03  8:10     ` Alex Shi
2013-03-30 14:35 ` [patch v6 14/21] sched: packing transitory tasks in wakeup power balancing Alex Shi
2013-03-30 14:35 ` [patch v6 15/21] sched: add power/performance balance allow flag Alex Shi
2013-03-30 14:35 ` [patch v6 16/21] sched: pull all tasks from source group Alex Shi
2013-03-30 14:35 ` [patch v6 17/21] sched: no balance for prefer_sibling in power scheduling Alex Shi
2013-03-30 14:35 ` [patch v6 18/21] sched: add new members of sd_lb_stats Alex Shi
2013-03-30 14:35 ` [patch v6 19/21] sched: power aware load balance Alex Shi
2013-03-30 14:35 ` [patch v6 20/21] sched: lazy power balance Alex Shi
2013-03-30 14:35 ` [patch v6 21/21] sched: don't do power balance on share cpu power domain Alex Shi
2013-04-01  5:05 ` [patch v6 0/21] sched: power aware scheduling Michael Wang
2013-04-01  6:17   ` Alex Shi
2013-04-01  6:20 ` Alex Shi
2013-04-03  8:17 ` Alex Shi
2013-04-04  0:57 ` Alex Shi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1364654108-16307-13-git-send-email-alex.shi@intel.com \
    --to=alex.shi@intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=arjan@linux.intel.com \
    --cc=bp@alien8.de \
    --cc=efault@gmx.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=pjt@google.com \
    --cc=preeti@linux.vnet.ibm.com \
    --cc=tglx@linutronix.de \
    --cc=vincent.guittot@linaro.org \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®