From: Alex Shi <alex.shi@intel.com>
To: mingo@redhat.com, peterz@infradead.org, tglx@linutronix.de,
akpm@linux-foundation.org, arjan@linux.intel.com, bp@alien8.de,
pjt@google.com, namhyung@kernel.org, efault@gmx.de
Cc: vincent.guittot@linaro.org, gregkh@linuxfoundation.org,
preeti@linux.vnet.ibm.com, viresh.kumar@linaro.org,
linux-kernel@vger.kernel.org, alex.shi@intel.com
Subject: [patch v6 16/21] sched: pull all tasks from source group
Date: Sat, 30 Mar 2013 22:35:03 +0800 [thread overview]
Message-ID: <1364654108-16307-17-git-send-email-alex.shi@intel.com> (raw)
In-Reply-To: <1364654108-16307-1-git-send-email-alex.shi@intel.com>
In power balance, we hope some sched groups are fully empty to save
CPU power of them. So, we want to move any tasks from them.
Signed-off-by: Alex Shi <alex.shi@intel.com>
---
kernel/sched/fair.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index adccdb8..d25fb3b 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -5115,7 +5115,9 @@ static struct rq *find_busiest_queue(struct lb_env *env,
* When comparing with imbalance, use weighted_cpuload()
* which is not scaled with the cpu power.
*/
- if (capacity && rq->nr_running == 1 && wl > env->imbalance)
+ if (rq->nr_running == 0 ||
+ (!(env->flags & LBF_POWER_BAL) && capacity &&
+ rq->nr_running == 1 && wl > env->imbalance))
continue;
/*
@@ -5218,7 +5220,8 @@ redo:
ld_moved = 0;
lb_iterations = 1;
- if (busiest->nr_running > 1) {
+ if (busiest->nr_running > 1 ||
+ (busiest->nr_running == 1 && env.flags & LBF_POWER_BAL)) {
/*
* Attempt to move tasks. If find_busiest_group has found
* an imbalance but busiest->nr_running <= 1, the group is
--
1.7.12
next prev parent reply other threads:[~2013-03-30 14:37 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-30 14:34 [patch v6 0/21] sched: power aware scheduling Alex Shi
2013-03-30 14:34 ` [patch v6 01/21] Revert "sched: Introduce temporary FAIR_GROUP_SCHED dependency for load-tracking" Alex Shi
2013-03-30 14:34 ` [patch v6 02/21] sched: set initial value of runnable avg for new forked task Alex Shi
2013-03-30 14:34 ` [patch v6 03/21] sched: only count runnable avg on cfs_rq's nr_running Alex Shi
2013-04-02 14:30 ` Vincent Guittot
2013-04-03 1:02 ` Alex Shi
2013-04-03 1:23 ` Paul Turner
2013-04-03 2:12 ` Alex Shi
2013-03-30 14:34 ` [patch v6 04/21] sched: add sched balance policies in kernel Alex Shi
2013-03-30 14:34 ` [patch v6 05/21] sched: add sysfs interface for sched_balance_policy selection Alex Shi
2013-03-30 14:34 ` [patch v6 06/21] sched: log the cpu utilization at rq Alex Shi
2013-03-30 14:34 ` [patch v6 07/21] sched: add new sg/sd_lb_stats fields for incoming fork/exec/wake balancing Alex Shi
2013-03-30 14:34 ` [patch v6 08/21] sched: move sg/sd_lb_stats struct ahead Alex Shi
2013-03-30 14:34 ` [patch v6 09/21] sched: scale_rt_power rename and meaning change Alex Shi
2013-03-30 14:34 ` [patch v6 10/21] sched: get rq potential maximum utilization Alex Shi
2013-04-02 9:02 ` Namhyung Kim
2013-04-02 13:38 ` Alex Shi
2013-04-03 2:15 ` Alex Shi
2013-04-03 2:22 ` Paul Turner
2013-04-03 2:35 ` Alex Shi
2013-04-03 8:07 ` Alex Shi
2013-04-02 14:38 ` Vincent Guittot
2013-04-03 1:11 ` Alex Shi
2013-03-30 14:34 ` [patch v6 11/21] sched: detect wakeup burst with rq->avg_idle Alex Shi
2013-04-03 8:12 ` Alex Shi
2013-03-30 14:34 ` [patch v6 12/21] sched: add power aware scheduling in fork/exec/wake Alex Shi
2013-04-01 9:50 ` Preeti U Murthy
2013-04-01 13:43 ` Alex Shi
2013-03-30 14:35 ` [patch v6 13/21] sched: using avg_idle to detect bursty wakeup Alex Shi
2013-04-03 5:08 ` Namhyung Kim
2013-04-03 5:41 ` Alex Shi
2013-04-03 8:10 ` Alex Shi
2013-03-30 14:35 ` [patch v6 14/21] sched: packing transitory tasks in wakeup power balancing Alex Shi
2013-03-30 14:35 ` [patch v6 15/21] sched: add power/performance balance allow flag Alex Shi
2013-03-30 14:35 ` Alex Shi [this message]
2013-03-30 14:35 ` [patch v6 17/21] sched: no balance for prefer_sibling in power scheduling Alex Shi
2013-03-30 14:35 ` [patch v6 18/21] sched: add new members of sd_lb_stats Alex Shi
2013-03-30 14:35 ` [patch v6 19/21] sched: power aware load balance Alex Shi
2013-03-30 14:35 ` [patch v6 20/21] sched: lazy power balance Alex Shi
2013-03-30 14:35 ` [patch v6 21/21] sched: don't do power balance on share cpu power domain Alex Shi
2013-04-01 5:05 ` [patch v6 0/21] sched: power aware scheduling Michael Wang
2013-04-01 6:17 ` Alex Shi
2013-04-01 6:20 ` Alex Shi
2013-04-03 8:17 ` Alex Shi
2013-04-04 0:57 ` Alex Shi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1364654108-16307-17-git-send-email-alex.shi@intel.com \
--to=alex.shi@intel.com \
--cc=akpm@linux-foundation.org \
--cc=arjan@linux.intel.com \
--cc=bp@alien8.de \
--cc=efault@gmx.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=pjt@google.com \
--cc=preeti@linux.vnet.ibm.com \
--cc=tglx@linutronix.de \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®