* [PATCH] clocksource: mxs_timer: Add semicolon at end of line
@ 2013-04-02 16:30 Fabio Estevam
2013-04-03 2:29 ` Shawn Guo
0 siblings, 1 reply; 4+ messages in thread
From: Fabio Estevam @ 2013-04-02 16:30 UTC (permalink / raw)
To: shawn.guo; +Cc: tglx, john.stultz, linux-kernel, festevam, Fabio Estevam
Fix the following build error:
drivers/clocksource/mxs_timer.c:304:1: error: expected ',' or ';' at end of input
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
drivers/clocksource/mxs_timer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clocksource/mxs_timer.c b/drivers/clocksource/mxs_timer.c
index a4d469b..02af420 100644
--- a/drivers/clocksource/mxs_timer.c
+++ b/drivers/clocksource/mxs_timer.c
@@ -301,4 +301,4 @@ static void __init mxs_timer_init(struct device_node *np)
irq = irq_of_parse_and_map(np, 0);
setup_irq(irq, &mxs_timer_irq);
}
-CLOCKSOURCE_OF_DECLARE(mxs, "fsl,timrot", mxs_timer_init)
+CLOCKSOURCE_OF_DECLARE(mxs, "fsl,timrot", mxs_timer_init);
--
1.7.9.5
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] clocksource: mxs_timer: Add semicolon at end of line
2013-04-02 16:30 [PATCH] clocksource: mxs_timer: Add semicolon at end of line Fabio Estevam
@ 2013-04-03 2:29 ` Shawn Guo
2013-04-03 2:56 ` Shawn Guo
0 siblings, 1 reply; 4+ messages in thread
From: Shawn Guo @ 2013-04-03 2:29 UTC (permalink / raw)
To: Fabio Estevam; +Cc: tglx, john.stultz, linux-kernel, festevam
On Tue, Apr 02, 2013 at 01:30:32PM -0300, Fabio Estevam wrote:
> Fix the following build error:
>
> drivers/clocksource/mxs_timer.c:304:1: error: expected ',' or ';' at end of input
>
What's your gcc version? I'm using gcc version 4.6.3 (Ubuntu/Linaro
4.6.3-1ubuntu5), and do not see the compile error.
Anyway, patch applied.
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
> drivers/clocksource/mxs_timer.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clocksource/mxs_timer.c b/drivers/clocksource/mxs_timer.c
> index a4d469b..02af420 100644
> --- a/drivers/clocksource/mxs_timer.c
> +++ b/drivers/clocksource/mxs_timer.c
> @@ -301,4 +301,4 @@ static void __init mxs_timer_init(struct device_node *np)
> irq = irq_of_parse_and_map(np, 0);
> setup_irq(irq, &mxs_timer_irq);
> }
> -CLOCKSOURCE_OF_DECLARE(mxs, "fsl,timrot", mxs_timer_init)
> +CLOCKSOURCE_OF_DECLARE(mxs, "fsl,timrot", mxs_timer_init);
I guess I took the bad example from drivers/clocksource/vt8500_timer.c.
Shawn
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] clocksource: mxs_timer: Add semicolon at end of line
2013-04-03 2:29 ` Shawn Guo
@ 2013-04-03 2:56 ` Shawn Guo
2013-04-03 3:17 ` Fabio Estevam
0 siblings, 1 reply; 4+ messages in thread
From: Shawn Guo @ 2013-04-03 2:56 UTC (permalink / raw)
To: Fabio Estevam; +Cc: Thomas Gleixner, John Stultz, linux-kernel, Fabio Estevam
On 3 April 2013 10:29, Shawn Guo <shawn.guo@linaro.org> wrote:
> On Tue, Apr 02, 2013 at 01:30:32PM -0300, Fabio Estevam wrote:
>> Fix the following build error:
>>
>> drivers/clocksource/mxs_timer.c:304:1: error: expected ',' or ';' at end of input
>>
> What's your gcc version? I'm using gcc version 4.6.3 (Ubuntu/Linaro
> 4.6.3-1ubuntu5), and do not see the compile error.
Ok, I'm seeing the error now on linux-next. It's not about compiler
but the commit 3d5a965 (clocksource: make CLOCKSOURCE_OF_DECLARE type
safe), which removes the semicolon at end of the
CLOCKSOURCE_OF_DECLARE definition.
Shawn
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] clocksource: mxs_timer: Add semicolon at end of line
2013-04-03 2:56 ` Shawn Guo
@ 2013-04-03 3:17 ` Fabio Estevam
0 siblings, 0 replies; 4+ messages in thread
From: Fabio Estevam @ 2013-04-03 3:17 UTC (permalink / raw)
To: Shawn Guo; +Cc: Fabio Estevam, Thomas Gleixner, John Stultz, linux-kernel
On Tue, Apr 2, 2013 at 11:56 PM, Shawn Guo <shawn.guo@linaro.org> wrote:
> Ok, I'm seeing the error now on linux-next. It's not about compiler
> but the commit 3d5a965 (clocksource: make CLOCKSOURCE_OF_DECLARE type
> safe), which removes the semicolon at end of the
> CLOCKSOURCE_OF_DECLARE definition.
Right, the removal of the semicolon at the end of
CLOCKSOURCE_OF_DECLARE definition is intentional in commit 3d5a965.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-04-03 3:17 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-04-02 16:30 [PATCH] clocksource: mxs_timer: Add semicolon at end of line Fabio Estevam
2013-04-03 2:29 ` Shawn Guo
2013-04-03 2:56 ` Shawn Guo
2013-04-03 3:17 ` Fabio Estevam
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®