* [PATCH 1/1] mmap.c: find_vma: eliminate initial if(mm) check
@ 2013-04-07 9:18 k80c
2013-04-07 10:13 ` Michel Lespinasse
0 siblings, 1 reply; 2+ messages in thread
From: k80c @ 2013-04-07 9:18 UTC (permalink / raw)
To: Andrew Morton, Michel Lespinasse, Rik van Riel, Al Viro, Ingo Molnar
Cc: linux-mm, linux-kernel, k80c
As per commit 841e31e5cc6219d62054788faa289b6ed682d068,
we dont really need this if(mm) check anymore.
A WARN_ON_ONCE was added just for safety, but there have been no bug
reports about this so far.
Removing this if(mm) check.
Signed-off-by: k80c <k80ck80c@gmail.com>
---
mm/mmap.c | 3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/mm/mmap.c b/mm/mmap.c
index 0db0de1..b2c363f 100644
--- a/mm/mmap.c
+++ b/mm/mmap.c
@@ -1935,9 +1935,6 @@ struct vm_area_struct *find_vma(struct mm_struct *mm, unsigned long addr)
{
struct vm_area_struct *vma = NULL;
- if (WARN_ON_ONCE(!mm)) /* Remove this in linux-3.6 */
- return NULL;
-
/* Check the cache first. */
/* (Cache hit rate is typically around 35%.) */
vma = ACCESS_ONCE(mm->mmap_cache);
--
1.7.5.4
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH 1/1] mmap.c: find_vma: eliminate initial if(mm) check
2013-04-07 9:18 [PATCH 1/1] mmap.c: find_vma: eliminate initial if(mm) check k80c
@ 2013-04-07 10:13 ` Michel Lespinasse
0 siblings, 0 replies; 2+ messages in thread
From: Michel Lespinasse @ 2013-04-07 10:13 UTC (permalink / raw)
To: k80c
Cc: Andrew Morton, Rik van Riel, Al Viro, Ingo Molnar, linux-mm,
linux-kernel
On Sun, Apr 7, 2013 at 2:18 AM, k80c <k80ck80c@gmail.com> wrote:
> As per commit 841e31e5cc6219d62054788faa289b6ed682d068,
> we dont really need this if(mm) check anymore.
>
> A WARN_ON_ONCE was added just for safety, but there have been no bug
> reports about this so far.
>
> Removing this if(mm) check.
>
> Signed-off-by: k80c <k80ck80c@gmail.com>
> ---
> mm/mmap.c | 3 ---
> 1 files changed, 0 insertions(+), 3 deletions(-)
>
> diff --git a/mm/mmap.c b/mm/mmap.c
> index 0db0de1..b2c363f 100644
> --- a/mm/mmap.c
> +++ b/mm/mmap.c
> @@ -1935,9 +1935,6 @@ struct vm_area_struct *find_vma(struct mm_struct *mm, unsigned long addr)
> {
> struct vm_area_struct *vma = NULL;
>
> - if (WARN_ON_ONCE(!mm)) /* Remove this in linux-3.6 */
> - return NULL;
> -
> /* Check the cache first. */
> /* (Cache hit rate is typically around 35%.) */
> vma = ACCESS_ONCE(mm->mmap_cache);
Looks good to me.
Reviewed-by: Michel Lespinasse <walken@google.com>
--
Michel "Walken" Lespinasse
A program is never fully debugged until the last user dies.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-04-07 10:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-04-07 9:18 [PATCH 1/1] mmap.c: find_vma: eliminate initial if(mm) check k80c
2013-04-07 10:13 ` Michel Lespinasse
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®