From: Namhyung Kim <namhyung@kernel.org>
To: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@kernel.org>,
Namhyung Kim <namhyung.kim@lge.com>,
LKML <linux-kernel@vger.kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
Frederic Weisbecker <fweisbec@gmail.com>
Subject: [PATCH 02/10] perf util: Save long size of traced system
Date: Mon, 15 Apr 2013 14:11:30 +0900 [thread overview]
Message-ID: <1366002698-10728-3-git-send-email-namhyung@kernel.org> (raw)
In-Reply-To: <1366002698-10728-1-git-send-email-namhyung@kernel.org>
From: Namhyung Kim <namhyung.kim@lge.com>
Save size of long type of system to struct pevent. Since original
static variable was not used anywhere, just get rid of it.
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
---
tools/perf/util/trace-event-read.c | 11 +++--------
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git a/tools/perf/util/trace-event-read.c b/tools/perf/util/trace-event-read.c
index c6b491bcb8cd..6166294d7f22 100644
--- a/tools/perf/util/trace-event-read.c
+++ b/tools/perf/util/trace-event-read.c
@@ -41,7 +41,6 @@ static int input_fd;
int file_bigendian;
int host_bigendian;
-static int long_size;
static ssize_t trace_data_size;
static bool repipe;
@@ -231,12 +230,6 @@ static int read_header_files(struct pevent *pevent)
size = read8(pevent);
skip(size);
- /*
- * The size field in the page is of type long,
- * use that instead, since it represents the kernel.
- */
- long_size = header_page_size_size;
-
if (do_read(buf, 13) < 0)
return -1;
@@ -349,6 +342,7 @@ ssize_t trace_report(int fd, struct pevent **ppevent, bool __repipe)
int show_funcs = 0;
int show_printk = 0;
ssize_t size = -1;
+ int file_long_size;
int file_page_size;
struct pevent *pevent;
int err;
@@ -392,12 +386,13 @@ ssize_t trace_report(int fd, struct pevent **ppevent, bool __repipe)
if (do_read(buf, 1) < 0)
goto out;
- long_size = buf[0];
+ file_long_size = buf[0];
file_page_size = read4(pevent);
if (!file_page_size)
goto out;
+ pevent_set_long_size(pevent, file_long_size);
pevent_set_page_size(pevent, file_page_size);
err = read_header_files(pevent);
--
1.7.11.7
next prev parent reply other threads:[~2013-04-15 5:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-15 5:11 [PATCHSET 00/10] perf util: More cleanups on tracepoint handling Namhyung Kim
2013-04-15 5:11 ` [PATCH 01/10] perf util: Save page size in a trace file to pevent Namhyung Kim
2013-04-15 5:11 ` Namhyung Kim [this message]
2013-04-15 5:11 ` [PATCH 03/10] perf util: Make file/host_bigendian variable local Namhyung Kim
2013-04-15 5:11 ` [PATCH 04/10] perf util: Skip reading header_event file Namhyung Kim
2013-04-15 5:11 ` [PATCH 05/10] perf util: Parse header_page to get proper long size Namhyung Kim
2013-04-17 3:59 ` [PATCH v2 " Namhyung Kim
2013-04-15 5:11 ` [PATCH 06/10] perf util: Get rid of unused header_page_* variables Namhyung Kim
2013-04-15 5:11 ` [PATCH 07/10] perf util: Move latency_format variable to builtin-script.c Namhyung Kim
2013-04-15 5:11 ` [PATCH 08/10] perf util: Rename read_*() functions in trace-event-info.c Namhyung Kim
2013-04-15 5:11 ` [PATCH 09/10] perf util: No need to call read_trace_init() in tracing_data_header() Namhyung Kim
2013-04-15 5:11 ` [PATCH 10/10] perf util: Remove unused enum and macro in trace-event.h Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1366002698-10728-3-git-send-email-namhyung@kernel.org \
--to=namhyung@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung.kim@lge.com \
--cc=paulus@samba.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®