From: Namhyung Kim <namhyung@kernel.org>
To: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@kernel.org>,
Namhyung Kim <namhyung.kim@lge.com>,
LKML <linux-kernel@vger.kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
Frederic Weisbecker <fweisbec@gmail.com>
Subject: [PATCH 08/10] perf util: Rename read_*() functions in trace-event-info.c
Date: Mon, 15 Apr 2013 14:11:36 +0900 [thread overview]
Message-ID: <1366002698-10728-9-git-send-email-namhyung@kernel.org> (raw)
In-Reply-To: <1366002698-10728-1-git-send-email-namhyung@kernel.org>
From: Namhyung Kim <namhyung.kim@lge.com>
It's confusing to have same name for two difference functions which
does something opposite way. Since what they do in this file is read
*AND* writing some of tracing metadata files, rename them to
record_*() looks better to me.
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
---
tools/perf/util/trace-event-info.c | 20 ++++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/tools/perf/util/trace-event-info.c b/tools/perf/util/trace-event-info.c
index 3917eb9a8479..9648175e2a1c 100644
--- a/tools/perf/util/trace-event-info.c
+++ b/tools/perf/util/trace-event-info.c
@@ -160,7 +160,7 @@ out:
return err;
}
-static int read_header_files(void)
+static int record_header_files(void)
{
char *path;
struct stat st;
@@ -299,7 +299,7 @@ out:
return err;
}
-static int read_ftrace_files(struct tracepoint_path *tps)
+static int record_ftrace_files(struct tracepoint_path *tps)
{
char *path;
int ret;
@@ -328,7 +328,7 @@ static bool system_in_tp_list(char *sys, struct tracepoint_path *tps)
return false;
}
-static int read_event_files(struct tracepoint_path *tps)
+static int record_event_files(struct tracepoint_path *tps)
{
struct dirent *dent;
struct stat st;
@@ -403,7 +403,7 @@ out:
return err;
}
-static int read_proc_kallsyms(void)
+static int record_proc_kallsyms(void)
{
unsigned int size;
const char *path = "/proc/kallsyms";
@@ -421,7 +421,7 @@ static int read_proc_kallsyms(void)
return record_file(path, 4);
}
-static int read_ftrace_printk(void)
+static int record_ftrace_printk(void)
{
unsigned int size;
char *path;
@@ -583,19 +583,19 @@ struct tracing_data *tracing_data_get(struct list_head *pattrs,
err = tracing_data_header();
if (err)
goto out;
- err = read_header_files();
+ err = record_header_files();
if (err)
goto out;
- err = read_ftrace_files(tps);
+ err = record_ftrace_files(tps);
if (err)
goto out;
- err = read_event_files(tps);
+ err = record_event_files(tps);
if (err)
goto out;
- err = read_proc_kallsyms();
+ err = record_proc_kallsyms();
if (err)
goto out;
- err = read_ftrace_printk();
+ err = record_ftrace_printk();
out:
/*
--
1.7.11.7
next prev parent reply other threads:[~2013-04-15 5:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-15 5:11 [PATCHSET 00/10] perf util: More cleanups on tracepoint handling Namhyung Kim
2013-04-15 5:11 ` [PATCH 01/10] perf util: Save page size in a trace file to pevent Namhyung Kim
2013-04-15 5:11 ` [PATCH 02/10] perf util: Save long size of traced system Namhyung Kim
2013-04-15 5:11 ` [PATCH 03/10] perf util: Make file/host_bigendian variable local Namhyung Kim
2013-04-15 5:11 ` [PATCH 04/10] perf util: Skip reading header_event file Namhyung Kim
2013-04-15 5:11 ` [PATCH 05/10] perf util: Parse header_page to get proper long size Namhyung Kim
2013-04-17 3:59 ` [PATCH v2 " Namhyung Kim
2013-04-15 5:11 ` [PATCH 06/10] perf util: Get rid of unused header_page_* variables Namhyung Kim
2013-04-15 5:11 ` [PATCH 07/10] perf util: Move latency_format variable to builtin-script.c Namhyung Kim
2013-04-15 5:11 ` Namhyung Kim [this message]
2013-04-15 5:11 ` [PATCH 09/10] perf util: No need to call read_trace_init() in tracing_data_header() Namhyung Kim
2013-04-15 5:11 ` [PATCH 10/10] perf util: Remove unused enum and macro in trace-event.h Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1366002698-10728-9-git-send-email-namhyung@kernel.org \
--to=namhyung@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung.kim@lge.com \
--cc=paulus@samba.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®