mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] mmc: host: sdhci: Fix console flooding when there is no proper card detection
@ 2013-04-25  8:18 maxin.john
  0 siblings, 0 replies; only message in thread
From: maxin.john @ 2013-04-25  8:18 UTC (permalink / raw)
  To: cjb; +Cc: linux-mmc, linux-kernel, maxin.john, Maxin B. John

From: "Maxin B. John" <maxin.john@enea.com>

With 3.9.0-rc8 kernel in p2020rdb powerpc target, the console gets
flooded with this message without any SD-Cards present:
"mmc0: Timeout waiting for hardware interrupt"

Since the driver doesn't implement proper card detection, it assumes that
card is always present. This quick-n-dirty patch removes this console
flooding.

In an ideal world, the driver should have "cd-gpio" support.

Signed-off-by: Maxin B. John <maxin.john@enea.com>
---
 drivers/mmc/host/sdhci.c |    8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
index 51bbba4..3347864 100644
--- a/drivers/mmc/host/sdhci.c
+++ b/drivers/mmc/host/sdhci.c
@@ -2131,10 +2131,18 @@ static void sdhci_timeout_timer(unsigned long data)
 	spin_lock_irqsave(&host->lock, flags);
 
 	if (host->mrq) {
+		/*
+		 * If the driver doesn't implement proper card detection,
+		 * we shouldn't flood the console with Timeout error messages.
+		 */
+		if (host->quirks & SDHCI_QUIRK_BROKEN_CARD_DETECTION)
+			goto data_check;
+
 		pr_err("%s: Timeout waiting for hardware "
 			"interrupt.\n", mmc_hostname(host->mmc));
 		sdhci_dumpregs(host);
 
+data_check:
 		if (host->data) {
 			host->data->error = -ETIMEDOUT;
 			sdhci_finish_data(host);
-- 
1.7.10.4


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2013-04-25  8:19 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-04-25  8:18 [PATCH] mmc: host: sdhci: Fix console flooding when there is no proper card detection maxin.john

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®