From: Jiri Olsa <jolsa@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: Jiri Olsa <jolsa@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>,
Andi Kleen <andi@firstfloor.org>, Oleg Nesterov <oleg@redhat.com>,
Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Ingo Molnar <mingo@elte.hu>, Paul Mackerras <paulus@samba.org>,
Corey Ashford <cjashfor@linux.vnet.ibm.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
Vince Weaver <vincent.weaver@maine.edu>,
Stephane Eranian <eranian@google.com>
Subject: [PATCH 3/4] signal x86: Merge EFLAGS bit clearing into single statement
Date: Wed, 1 May 2013 17:25:43 +0200 [thread overview]
Message-ID: <1367421944-19082-4-git-send-email-jolsa@redhat.com> (raw)
In-Reply-To: <1367421944-19082-1-git-send-email-jolsa@redhat.com>
Merging EFLAGS bit clearing into a single statement, to
ensure EFLAGS bits being cleared in single instruction.
Signed-off-by: Jiri Olsa <jolsa@redhat.com>
Tested-by: Oleg Nesterov <oleg@redhat.com>
Reviewed-by: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Andi Kleen <andi@firstfloor.org>
Cc: Oleg Nesterov <oleg@redhat.com>
Cc: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Corey Ashford <cjashfor@linux.vnet.ibm.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Vince Weaver <vincent.weaver@maine.edu>
Cc: Stephane Eranian <eranian@google.com>
---
arch/x86/kernel/signal.c | 10 +++-------
1 file changed, 3 insertions(+), 7 deletions(-)
diff --git a/arch/x86/kernel/signal.c b/arch/x86/kernel/signal.c
index cb12fc9..cf91358 100644
--- a/arch/x86/kernel/signal.c
+++ b/arch/x86/kernel/signal.c
@@ -662,21 +662,17 @@ handle_signal(struct ksignal *ksig, struct pt_regs *regs)
if (!failed) {
/*
* Clear the direction flag as per the ABI for function entry.
- */
- regs->flags &= ~X86_EFLAGS_DF;
- /*
+ *
* Clear RF when entering the signal handler, because
* it might disable possible debug exception from the
* signal handler.
- */
- regs->flags &= ~X86_EFLAGS_RF;
- /*
+ *
* Clear TF when entering the signal handler, but
* notify any tracer that was single-stepping it.
* The tracer may want to single-step inside the
* handler too.
*/
- regs->flags &= ~X86_EFLAGS_TF;
+ regs->flags &= ~(X86_EFLAGS_DF|X86_EFLAGS_RF|X86_EFLAGS_TF);
}
signal_setup_done(failed, ksig, test_thread_flag(TIF_SINGLESTEP));
}
--
1.7.11.7
next prev parent reply other threads:[~2013-05-01 15:26 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-01 15:25 [PATCHv3 0/4] perf, signal x86: Fix breakpoint events overflow handling Jiri Olsa
2013-05-01 15:25 ` [PATCH 1/4] signal x86: Propage RF EFLAGS bit throught the signal restore call Jiri Olsa
2013-05-28 12:51 ` [tip:perf/core] x86/signals: Propagate RF EFLAGS bit through " tip-bot for Jiri Olsa
2013-05-01 15:25 ` [PATCH 2/4] signal x86: Clear RF EFLAGS bit for signal handler Jiri Olsa
2013-05-28 12:52 ` [tip:perf/core] x86/signals: " tip-bot for Jiri Olsa
2013-05-01 15:25 ` Jiri Olsa [this message]
2013-05-28 12:54 ` [tip:perf/core] x86/signals: Merge EFLAGS bit clearing into a single statement tip-bot for Jiri Olsa
2013-05-01 15:25 ` [PATCH 4/4] perf: Fix hw breakpoints overflow period sampling Jiri Olsa
2013-05-28 12:56 ` [tip:perf/core] " tip-bot for Jiri Olsa
2013-05-01 15:52 ` [PATCHv3 0/4] perf, signal x86: Fix breakpoint events overflow handling Oleg Nesterov
2013-05-07 12:29 ` Jiri Olsa
2013-05-15 15:04 ` Jiri Olsa
2013-05-15 15:44 ` Frederic Weisbecker
2013-05-15 19:28 ` Jiri Olsa
2013-05-15 16:52 ` Peter Zijlstra
2013-05-15 19:28 ` Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1367421944-19082-4-git-send-email-jolsa@redhat.com \
--to=jolsa@redhat.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=andi@firstfloor.org \
--cc=cjashfor@linux.vnet.ibm.com \
--cc=eranian@google.com \
--cc=fweisbec@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=oleg@redhat.com \
--cc=paulus@samba.org \
--cc=tglx@linutronix.de \
--cc=vincent.weaver@maine.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome