mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Michel Lespinasse <walken@google.com>
To: Linus Torvalds <torvalds@linux-foundation.org>,
	David Howells <dhowells@redhat.com>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Ingo Molnar <mingo@kernel.org>, Rik van Riel <riel@redhat.com>,
	Davidlohr Bueso <davidlohr.bueso@hp.com>,
	Peter Hurley <peter@hurleysoftware.com>
Cc: Alex Shi <alex.shi@intel.com>,
	Yuanhan Liu <yuanhan.liu@linux.intel.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org
Subject: [PATCH v3 14/14] rwsem: no need for explicit signed longs
Date: Tue,  7 May 2013 06:46:02 -0700	[thread overview]
Message-ID: <1367934362-10433-15-git-send-email-walken@google.com> (raw)
In-Reply-To: <1367934362-10433-1-git-send-email-walken@google.com>

From: Davidlohr Bueso <davidlohr.bueso@hp.com>

Change explicit "signed long" declarations into plain "long" as suggested
by Peter Hurley.

Signed-off-by: Davidlohr Bueso <davidlohr.bueso@hp.com>
Reviewed-by: Michel Lespinasse <walken@google.com>
Signed-off-by: Michel Lespinasse <walken@google.com>
---
 lib/rwsem.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/lib/rwsem.c b/lib/rwsem.c
index 61f91ca75e40..cf0ad2ad19f5 100644
--- a/lib/rwsem.c
+++ b/lib/rwsem.c
@@ -64,7 +64,7 @@ __rwsem_do_wake(struct rw_semaphore *sem, enum rwsem_wake_type wake_type)
 	struct rwsem_waiter *waiter;
 	struct task_struct *tsk;
 	struct list_head *next;
-	signed long oldcount, woken, loop, adjustment;
+	long oldcount, woken, loop, adjustment;
 
 	waiter = list_entry(sem->wait_list.next, struct rwsem_waiter, list);
 	if (waiter->type == RWSEM_WAITING_FOR_WRITE) {
@@ -145,10 +145,9 @@ __rwsem_do_wake(struct rw_semaphore *sem, enum rwsem_wake_type wake_type)
  */
 struct rw_semaphore __sched *rwsem_down_read_failed(struct rw_semaphore *sem)
 {
-	signed long adjustment = -RWSEM_ACTIVE_READ_BIAS;
+	long count, adjustment = -RWSEM_ACTIVE_READ_BIAS;
 	struct rwsem_waiter waiter;
 	struct task_struct *tsk = current;
-	signed long count;
 
 	/* set up my own style of waitqueue */
 	waiter.task = tsk;
@@ -193,10 +192,9 @@ struct rw_semaphore __sched *rwsem_down_read_failed(struct rw_semaphore *sem)
  */
 struct rw_semaphore __sched *rwsem_down_write_failed(struct rw_semaphore *sem)
 {
-	signed long adjustment = -RWSEM_ACTIVE_WRITE_BIAS;
+	long count, adjustment = -RWSEM_ACTIVE_WRITE_BIAS;
 	struct rwsem_waiter waiter;
 	struct task_struct *tsk = current;
-	signed long count;
 
 	/* set up my own style of waitqueue */
 	waiter.task = tsk;
-- 
1.8.2.1


  parent reply	other threads:[~2013-05-07 13:46 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-07 13:45 [PATCH v3 00/14] rwsem fast-path write lock stealing Michel Lespinasse
2013-05-07 13:45 ` [PATCH v3 01/14] rwsem: make the waiter type an enumeration rather than a bitmask Michel Lespinasse
2013-05-07 13:45 ` [PATCH v3 02/14] rwsem: shorter spinlocked section in rwsem_down_failed_common() Michel Lespinasse
2013-05-07 13:45 ` [PATCH v3 03/14] rwsem: move rwsem_down_failed_common code into rwsem_down_{read,write}_failed Michel Lespinasse
2013-05-07 13:45 ` [PATCH v3 04/14] rwsem: simplify rwsem_down_read_failed Michel Lespinasse
2013-05-07 13:45 ` [PATCH v3 05/14] rwsem: simplify rwsem_down_write_failed Michel Lespinasse
2013-05-07 13:45 ` [PATCH v3 06/14] rwsem: more agressive lock stealing in rwsem_down_write_failed Michel Lespinasse
2013-05-07 13:45 ` [PATCH v3 07/14] rwsem: use cmpxchg for trying to steal write lock Michel Lespinasse
2013-05-07 13:45 ` [PATCH v3 08/14] rwsem: avoid taking wait_lock in rwsem_down_write_failed Michel Lespinasse
2013-05-07 13:45 ` [PATCH v3 09/14] rwsem: skip initial trylock " Michel Lespinasse
2013-05-07 13:45 ` [PATCH v3 10/14] rwsem: simplify __rwsem_do_wake Michel Lespinasse
2013-05-07 13:45 ` [PATCH v3 11/14] rwsem: implement support for write lock stealing on the fastpath Michel Lespinasse
2013-05-07 13:46 ` [PATCH v3 12/14] rwsem: do not block readers at head of queue if other readers are active Michel Lespinasse
2013-05-07 13:46 ` [PATCH v3 13/14] x86 rwsem: avoid taking slow path when stealing write lock Michel Lespinasse
2013-05-07 13:46 ` Michel Lespinasse [this message]
2013-05-07 22:39 ` [PATCH v3 15/14] rwsem: check counter to avoid cmpxchg calls Davidlohr Bueso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1367934362-10433-15-git-send-email-walken@google.com \
    --to=walken@google.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=akpm@linux-foundation.org \
    --cc=alex.shi@intel.com \
    --cc=davidlohr.bueso@hp.com \
    --cc=dhowells@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=peter@hurleysoftware.com \
    --cc=riel@redhat.com \
    --cc=torvalds@linux-foundation.org \
    --cc=yuanhan.liu@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®