From: Michel Lespinasse <walken@google.com>
To: Linus Torvalds <torvalds@linux-foundation.org>,
David Howells <dhowells@redhat.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Ingo Molnar <mingo@kernel.org>, Rik van Riel <riel@redhat.com>,
Davidlohr Bueso <davidlohr.bueso@hp.com>,
Peter Hurley <peter@hurleysoftware.com>
Cc: Alex Shi <alex.shi@intel.com>,
Yuanhan Liu <yuanhan.liu@linux.intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: [PATCH v3 08/14] rwsem: avoid taking wait_lock in rwsem_down_write_failed
Date: Tue, 7 May 2013 06:45:56 -0700 [thread overview]
Message-ID: <1367934362-10433-9-git-send-email-walken@google.com> (raw)
In-Reply-To: <1367934362-10433-1-git-send-email-walken@google.com>
In rwsem_down_write_failed(), if there are active locks after we wake up
(i.e. the lock got stolen from us), skip taking the wait_lock and go back
to sleep immediately.
Signed-off-by: Michel Lespinasse <walken@google.com>
Reviewed-by: Peter Hurley <peter@hurleysoftware.com>
Acked-by: Davidlohr Bueso <davidlohr.bueso@hp.com>
Acked-by: Rik van Riel <riel@redhat.com>
---
lib/rwsem.c | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/lib/rwsem.c b/lib/rwsem.c
index 64c2dc007be2..edf3d9ca670e 100644
--- a/lib/rwsem.c
+++ b/lib/rwsem.c
@@ -214,8 +214,8 @@ struct rw_semaphore __sched *rwsem_down_write_failed(struct rw_semaphore *sem)
sem = __rwsem_do_wake(sem, RWSEM_WAKE_READ_OWNED);
/* wait until we successfully acquire the lock */
+ set_task_state(tsk, TASK_UNINTERRUPTIBLE);
while (true) {
- set_task_state(tsk, TASK_UNINTERRUPTIBLE);
/* Try acquiring the write lock. */
count = RWSEM_ACTIVE_WRITE_BIAS;
@@ -226,7 +226,13 @@ struct rw_semaphore __sched *rwsem_down_write_failed(struct rw_semaphore *sem)
break;
raw_spin_unlock_irq(&sem->wait_lock);
- schedule();
+
+ /* Block until there are no active lockers. */
+ do {
+ schedule();
+ set_task_state(tsk, TASK_UNINTERRUPTIBLE);
+ } while (sem->count & RWSEM_ACTIVE_MASK);
+
raw_spin_lock_irq(&sem->wait_lock);
}
--
1.8.2.1
next prev parent reply other threads:[~2013-05-07 13:48 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-07 13:45 [PATCH v3 00/14] rwsem fast-path write lock stealing Michel Lespinasse
2013-05-07 13:45 ` [PATCH v3 01/14] rwsem: make the waiter type an enumeration rather than a bitmask Michel Lespinasse
2013-05-07 13:45 ` [PATCH v3 02/14] rwsem: shorter spinlocked section in rwsem_down_failed_common() Michel Lespinasse
2013-05-07 13:45 ` [PATCH v3 03/14] rwsem: move rwsem_down_failed_common code into rwsem_down_{read,write}_failed Michel Lespinasse
2013-05-07 13:45 ` [PATCH v3 04/14] rwsem: simplify rwsem_down_read_failed Michel Lespinasse
2013-05-07 13:45 ` [PATCH v3 05/14] rwsem: simplify rwsem_down_write_failed Michel Lespinasse
2013-05-07 13:45 ` [PATCH v3 06/14] rwsem: more agressive lock stealing in rwsem_down_write_failed Michel Lespinasse
2013-05-07 13:45 ` [PATCH v3 07/14] rwsem: use cmpxchg for trying to steal write lock Michel Lespinasse
2013-05-07 13:45 ` Michel Lespinasse [this message]
2013-05-07 13:45 ` [PATCH v3 09/14] rwsem: skip initial trylock in rwsem_down_write_failed Michel Lespinasse
2013-05-07 13:45 ` [PATCH v3 10/14] rwsem: simplify __rwsem_do_wake Michel Lespinasse
2013-05-07 13:45 ` [PATCH v3 11/14] rwsem: implement support for write lock stealing on the fastpath Michel Lespinasse
2013-05-07 13:46 ` [PATCH v3 12/14] rwsem: do not block readers at head of queue if other readers are active Michel Lespinasse
2013-05-07 13:46 ` [PATCH v3 13/14] x86 rwsem: avoid taking slow path when stealing write lock Michel Lespinasse
2013-05-07 13:46 ` [PATCH v3 14/14] rwsem: no need for explicit signed longs Michel Lespinasse
2013-05-07 22:39 ` [PATCH v3 15/14] rwsem: check counter to avoid cmpxchg calls Davidlohr Bueso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1367934362-10433-9-git-send-email-walken@google.com \
--to=walken@google.com \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=alex.shi@intel.com \
--cc=davidlohr.bueso@hp.com \
--cc=dhowells@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peter@hurleysoftware.com \
--cc=riel@redhat.com \
--cc=torvalds@linux-foundation.org \
--cc=yuanhan.liu@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®