From: Namhyung Kim <namhyung@kernel.org>
To: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@kernel.org>,
Namhyung Kim <namhyung.kim@lge.com>,
LKML <linux-kernel@vger.kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Jiri Olsa <jolsa@redhat.com>, David Ahern <dsahern@gmail.com>,
Stephane Eranian <eranian@google.com>
Subject: [PATCH 12/15] perf ftrace: Use pager for displaying result
Date: Tue, 14 May 2013 19:13:56 +0900 [thread overview]
Message-ID: <1368526439-31966-13-git-send-email-namhyung@kernel.org> (raw)
In-Reply-To: <1368526439-31966-1-git-send-email-namhyung@kernel.org>
From: Namhyung Kim <namhyung.kim@lge.com>
It's convenient to use pager when seeing many lines of result.
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
---
tools/perf/builtin-ftrace.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/tools/perf/builtin-ftrace.c b/tools/perf/builtin-ftrace.c
index de6afd50cff2..588d61de1c89 100644
--- a/tools/perf/builtin-ftrace.c
+++ b/tools/perf/builtin-ftrace.c
@@ -227,6 +227,7 @@ static int do_ftrace_live(struct perf_ftrace *ftrace)
signal(SIGINT, sig_handler);
signal(SIGUSR1, sig_handler);
signal(SIGCHLD, sig_handler);
+ signal(SIGPIPE, sig_handler);
if (setup_tracing_files(ftrace) < 0)
goto out_reset;
@@ -1472,6 +1473,8 @@ __cmd_ftrace_live(struct perf_ftrace *ftrace, int argc, const char **argv)
if (!argc && perf_target__none(&ftrace->target))
usage_with_options(live_usage, live_options);
+ setup_pager();
+
ret = perf_target__validate(&ftrace->target);
if (ret) {
char errbuf[512];
@@ -1618,6 +1621,8 @@ __cmd_ftrace_show(struct perf_ftrace *ftrace, int argc, const char **argv)
if (ftrace->dirname == NULL)
ftrace->dirname = DEFAULT_DIRNAME;
+ setup_pager();
+
ret = do_ftrace_show(ftrace);
perf_evlist__delete_maps(ftrace->evlist);
@@ -1679,6 +1684,7 @@ __cmd_ftrace_report(struct perf_ftrace *ftrace, int argc, const char **argv)
perf_hpp__column_enable(PERF_HPP__OVERHEAD);
perf_hpp__init();
+ setup_pager();
setup_sorting();
symbol_conf.exclude_other = false;
--
1.7.11.7
next prev parent reply other threads:[~2013-05-14 10:15 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-14 10:13 [PATCHSET 00/15] perf tools: Introduce new 'ftrace' command (v2) Namhyung Kim
2013-05-14 10:13 ` [PATCH 01/15] perf util: Move debugfs/tracing helper functions to util.c Namhyung Kim
2013-05-14 10:13 ` [PATCH 02/15] perf util: Use evsel->name to get tracepoint_paths Namhyung Kim
2013-05-15 14:59 ` Jiri Olsa
2013-05-16 2:13 ` Namhyung Kim
2013-05-14 10:13 ` [PATCH 03/15] perf util: Save pid-cmdline mapping into tracing header Namhyung Kim
2013-05-15 21:21 ` Jiri Olsa
2013-05-16 2:51 ` Namhyung Kim
2013-05-14 10:13 ` [PATCH 04/15] perf util: Add more debug message on failure path Namhyung Kim
2013-05-14 10:13 ` [PATCH 05/15] perf tools: Introduce new 'ftrace' tool Namhyung Kim
2013-05-14 10:13 ` [PATCH 06/15] perf ftrace: Add support for --pid option Namhyung Kim
2013-05-14 10:13 ` [PATCH 07/15] perf ftrace: Add support for -a and -C option Namhyung Kim
2013-05-14 10:13 ` [PATCH 08/15] perf ftrace: Split "live" sub-command Namhyung Kim
2013-05-14 10:13 ` [PATCH 09/15] perf ftrace: Add 'record' sub-command Namhyung Kim
2013-05-15 21:20 ` Jiri Olsa
2013-05-16 2:24 ` Namhyung Kim
2013-05-15 21:21 ` Jiri Olsa
2013-05-16 2:43 ` Namhyung Kim
2013-05-14 10:13 ` [PATCH 10/15] perf ftrace: Add 'show' sub-command Namhyung Kim
2013-05-15 21:21 ` Jiri Olsa
2013-05-16 2:47 ` Namhyung Kim
2013-05-14 10:13 ` [PATCH 11/15] perf ftrace: Add 'report' sub-command Namhyung Kim
2013-05-14 10:13 ` Namhyung Kim [this message]
2013-05-14 10:13 ` [PATCH 13/15] perf ftrace: Cleanup using ftrace_setup/teardown() Namhyung Kim
2013-05-14 10:13 ` [PATCH 14/15] perf tools: Add document for perf-ftrace command Namhyung Kim
2013-05-14 10:13 ` [PATCH 15/15] perf ftrace: Add a signal handler for SIGSEGV Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1368526439-31966-13-git-send-email-namhyung@kernel.org \
--to=namhyung@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=dsahern@gmail.com \
--cc=eranian@google.com \
--cc=fweisbec@gmail.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung.kim@lge.com \
--cc=paulus@samba.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®