From: Namhyung Kim <namhyung@kernel.org>
To: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@kernel.org>,
Namhyung Kim <namhyung.kim@lge.com>,
LKML <linux-kernel@vger.kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Jiri Olsa <jolsa@redhat.com>, David Ahern <dsahern@gmail.com>,
Stephane Eranian <eranian@google.com>
Subject: [PATCH 02/15] perf util: Use evsel->name to get tracepoint_paths
Date: Tue, 14 May 2013 19:13:46 +0900 [thread overview]
Message-ID: <1368526439-31966-3-git-send-email-namhyung@kernel.org> (raw)
In-Reply-To: <1368526439-31966-1-git-send-email-namhyung@kernel.org>
From: Namhyung Kim <namhyung.kim@lge.com>
Most tracepoint events already have their system and event name in
->name field so that searching whole event tracing directory for each
evsel to match given id is suboptimal.
Factor out this routine into tracepoint_name_to_path().
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
---
tools/perf/util/parse-events.c | 23 +++++++++++++++++++++++
tools/perf/util/parse-events.h | 1 +
tools/perf/util/trace-event-info.c | 11 +++++++++++
3 files changed, 35 insertions(+)
diff --git a/tools/perf/util/parse-events.c b/tools/perf/util/parse-events.c
index 6c8bb0fb189b..1ae166c9da79 100644
--- a/tools/perf/util/parse-events.c
+++ b/tools/perf/util/parse-events.c
@@ -217,6 +217,29 @@ struct tracepoint_path *tracepoint_id_to_path(u64 config)
return NULL;
}
+struct tracepoint_path *tracepoint_name_to_path(const char *name)
+{
+ struct tracepoint_path *path = zalloc(sizeof(*path));
+ char *str = strchr(name, ':');
+
+ if (path == NULL || str == NULL) {
+ free(path);
+ return NULL;
+ }
+
+ path->system = strndup(name, str - name);
+ path->name = strdup(str+1);
+
+ if (path->system == NULL || path->name == NULL) {
+ free(path->system);
+ free(path->name);
+ free(path);
+ path = NULL;
+ }
+
+ return path;
+}
+
const char *event_type(int type)
{
switch (type) {
diff --git a/tools/perf/util/parse-events.h b/tools/perf/util/parse-events.h
index 8a4859315fd9..080f7cf25d99 100644
--- a/tools/perf/util/parse-events.h
+++ b/tools/perf/util/parse-events.h
@@ -23,6 +23,7 @@ struct tracepoint_path {
};
extern struct tracepoint_path *tracepoint_id_to_path(u64 config);
+extern struct tracepoint_path *tracepoint_name_to_path(const char *name);
extern bool have_tracepoints(struct list_head *evlist);
const char *event_type(int type);
diff --git a/tools/perf/util/trace-event-info.c b/tools/perf/util/trace-event-info.c
index ab18bf12d54a..bfcaeac7ef9d 100644
--- a/tools/perf/util/trace-event-info.c
+++ b/tools/perf/util/trace-event-info.c
@@ -414,12 +414,23 @@ get_tracepoints_path(struct list_head *pattrs)
if (pos->attr.type != PERF_TYPE_TRACEPOINT)
continue;
++nr_tracepoints;
+
+ if (pos->name) {
+ ppath->next = tracepoint_name_to_path(pos->name);
+ if (!ppath->next)
+ goto error;
+
+ goto next;
+ }
+
ppath->next = tracepoint_id_to_path(pos->attr.config);
if (!ppath->next) {
+error:
pr_debug("No memory to alloc tracepoints list\n");
put_tracepoints_path(&path);
return NULL;
}
+next:
ppath = ppath->next;
}
--
1.7.11.7
next prev parent reply other threads:[~2013-05-14 10:14 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-14 10:13 [PATCHSET 00/15] perf tools: Introduce new 'ftrace' command (v2) Namhyung Kim
2013-05-14 10:13 ` [PATCH 01/15] perf util: Move debugfs/tracing helper functions to util.c Namhyung Kim
2013-05-14 10:13 ` Namhyung Kim [this message]
2013-05-15 14:59 ` [PATCH 02/15] perf util: Use evsel->name to get tracepoint_paths Jiri Olsa
2013-05-16 2:13 ` Namhyung Kim
2013-05-14 10:13 ` [PATCH 03/15] perf util: Save pid-cmdline mapping into tracing header Namhyung Kim
2013-05-15 21:21 ` Jiri Olsa
2013-05-16 2:51 ` Namhyung Kim
2013-05-14 10:13 ` [PATCH 04/15] perf util: Add more debug message on failure path Namhyung Kim
2013-05-14 10:13 ` [PATCH 05/15] perf tools: Introduce new 'ftrace' tool Namhyung Kim
2013-05-14 10:13 ` [PATCH 06/15] perf ftrace: Add support for --pid option Namhyung Kim
2013-05-14 10:13 ` [PATCH 07/15] perf ftrace: Add support for -a and -C option Namhyung Kim
2013-05-14 10:13 ` [PATCH 08/15] perf ftrace: Split "live" sub-command Namhyung Kim
2013-05-14 10:13 ` [PATCH 09/15] perf ftrace: Add 'record' sub-command Namhyung Kim
2013-05-15 21:20 ` Jiri Olsa
2013-05-16 2:24 ` Namhyung Kim
2013-05-15 21:21 ` Jiri Olsa
2013-05-16 2:43 ` Namhyung Kim
2013-05-14 10:13 ` [PATCH 10/15] perf ftrace: Add 'show' sub-command Namhyung Kim
2013-05-15 21:21 ` Jiri Olsa
2013-05-16 2:47 ` Namhyung Kim
2013-05-14 10:13 ` [PATCH 11/15] perf ftrace: Add 'report' sub-command Namhyung Kim
2013-05-14 10:13 ` [PATCH 12/15] perf ftrace: Use pager for displaying result Namhyung Kim
2013-05-14 10:13 ` [PATCH 13/15] perf ftrace: Cleanup using ftrace_setup/teardown() Namhyung Kim
2013-05-14 10:13 ` [PATCH 14/15] perf tools: Add document for perf-ftrace command Namhyung Kim
2013-05-14 10:13 ` [PATCH 15/15] perf ftrace: Add a signal handler for SIGSEGV Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1368526439-31966-3-git-send-email-namhyung@kernel.org \
--to=namhyung@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=dsahern@gmail.com \
--cc=eranian@google.com \
--cc=fweisbec@gmail.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung.kim@lge.com \
--cc=paulus@samba.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®