[PATCH 2/2] Staging: android: sync: use seq_puts()/seq_putc() to follow coding style

[PATCH 2/2] Staging: android: sync: use seq_puts()/seq_putc() to follow coding style

[bmheight]

From: Brandon Height <bmheight@gmail.com>

Utilized seq_puts() for strings without format specifiers.
Utilized seq_putc() for seq_printf(s, "\n")

Signed-off-by: Brandon Height <bmheight@gmail.com>
---
 drivers/staging/android/sync.c | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/drivers/staging/android/sync.c b/drivers/staging/android/sync.c
index 36ed35e..a7891e6 100644
--- a/drivers/staging/android/sync.c
+++ b/drivers/staging/android/sync.c
@@ -875,11 +875,11 @@ static void sync_print_pt(struct seq_file *s, struct sync_pt *pt, bool fence)
 			seq_printf(s, " / %s", value);
 		}
 	} else if (pt->parent->ops->print_pt) {
-		seq_printf(s, ": ");
+		seq_puts(s, ": ");
 		pt->parent->ops->print_pt(s, pt);
 	}
 
-	seq_printf(s, "\n");
+	seq_putc(s, '\n');
 }
 
 static void sync_print_obj(struct seq_file *s, struct sync_timeline *obj)
@@ -894,11 +894,11 @@ static void sync_print_obj(struct seq_file *s, struct sync_timeline *obj)
 		obj->ops->timeline_value_str(obj, value, sizeof(value));
 		seq_printf(s, ": %s", value);
 	} else if (obj->ops->print_obj) {
-		seq_printf(s, ": ");
+		seq_puts(s, ": ");
 		obj->ops->print_obj(s, obj);
 	}
 
-	seq_printf(s, "\n");
+	seq_putc(s, '\n');
 
 	spin_lock_irqsave(&obj->child_list_lock, flags);
 	list_for_each(pos, &obj->child_list_head) {
@@ -939,7 +939,7 @@ static int sync_debugfs_show(struct seq_file *s, void *unused)
 	unsigned long flags;
 	struct list_head *pos;
 
-	seq_printf(s, "objs:\n--------------\n");
+	seq_puts(s, "objs:\n--------------\n");
 
 	spin_lock_irqsave(&sync_timeline_list_lock, flags);
 	list_for_each(pos, &sync_timeline_list_head) {
@@ -948,11 +948,11 @@ static int sync_debugfs_show(struct seq_file *s, void *unused)
 				     sync_timeline_list);
 
 		sync_print_obj(s, obj);
-		seq_printf(s, "\n");
+		seq_putc(s, '\n');
 	}
 	spin_unlock_irqrestore(&sync_timeline_list_lock, flags);
 
-	seq_printf(s, "fences:\n--------------\n");
+	seq_puts(s, "fences:\n--------------\n");
 
 	spin_lock_irqsave(&sync_fence_list_lock, flags);
 	list_for_each(pos, &sync_fence_list_head) {
@@ -960,7 +960,7 @@ static int sync_debugfs_show(struct seq_file *s, void *unused)
 			container_of(pos, struct sync_fence, sync_fence_list);
 
 		sync_print_fence(s, fence);
-		seq_printf(s, "\n");
+		seq_putc(s, '\n');
 	}
 	spin_unlock_irqrestore(&sync_fence_list_lock, flags);
 	return 0;
-- 
1.8.1.2

Re: [PATCH 2/2] Staging: android: sync: use seq_puts()/seq_putc() to follow coding style

[Greg KH]

On Thu, May 16, 2013 at 10:30:02AM -1000, bmheight@gmail.com wrote:
> From: Brandon Height <bmheight@gmail.com>
> 
> Utilized seq_puts() for strings without format specifiers.
> Utilized seq_putc() for seq_printf(s, "\n")
> 
> Signed-off-by: Brandon Height <bmheight@gmail.com>

Where patch 1/2 in this series?

confused,

greg k-h

Re: [PATCH 2/2] Staging: android: sync: use seq_puts()/seq_putc() to follow coding style

[Greg KH]

On Thu, May 16, 2013 at 10:30:02AM -1000, bmheight@gmail.com wrote:
> From: Brandon Height <bmheight@gmail.com>
> 
> Utilized seq_puts() for strings without format specifiers.
> Utilized seq_putc() for seq_printf(s, "\n")
> 
> Signed-off-by: Brandon Height <bmheight@gmail.com>

Sorry, someone beat you to this same patch a few days ago, so I can't
apply it.

greg k-h