mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Huang Shijie <b32955@freescale.com>
To: <dwmw2@infradead.org>
Cc: <dedekind1@gmail.com>, <computersforpeace@gmail.com>,
	<linux-mtd@lists.infradead.org>, <linux-kernel@vger.kernel.org>,
	<vikram186@gmail.com>, Huang Shijie <b32955@freescale.com>
Subject: [PATCH v6 07/10] mtd: add ECC info for nand_flash_dev{}
Date: Fri, 17 May 2013 11:17:31 +0800	[thread overview]
Message-ID: <1368760654-28754-8-git-send-email-b32955@freescale.com> (raw)
In-Reply-To: <1368760654-28754-1-git-send-email-b32955@freescale.com>

Add an instance of an anonymous struct to store the ECC infor for full id
nand chips.
	@ecc.strength_ds: ECC correctability from the datasheet.
	@ecc.step_ds: ECC size required by the @ecc.strength_ds,

These two fields are all from the datasheet.

Also add the necessary macros to make the code simple and clean.

Signed-off-by: Huang Shijie <b32955@freescale.com>
---
 include/linux/mtd/nand.h |   15 +++++++++++++++
 1 files changed, 15 insertions(+), 0 deletions(-)

diff --git a/include/linux/mtd/nand.h b/include/linux/mtd/nand.h
index 9574e0a..217cdfe 100644
--- a/include/linux/mtd/nand.h
+++ b/include/linux/mtd/nand.h
@@ -625,6 +625,11 @@ struct nand_chip {
 	{ .name = (nm), {{ .dev_id = (devid) }}, .chipsize = (chipsz), \
 	  .options = (opts) }
 
+#define NAND_ECC_INFO(_strength, _step)	\
+			{ .strength_ds = (_strength), .step_ds = (_step) }
+#define NAND_ECC_STRENGTH(type)		((type)->ecc.strength_ds)
+#define NAND_ECC_STEP(type)		((type)->ecc.step_ds)
+
 /**
  * struct nand_flash_dev - NAND Flash Device ID Structure
  * @name: a human-readable name of the NAND chip
@@ -642,6 +647,12 @@ struct nand_chip {
  * @options: stores various chip bit options
  * @id_len: The valid length of the @id.
  * @oobsize: OOB size
+ * @ecc.strength_ds: The ECC correctability from the datasheet, same as the
+ *                   @ecc_strength_ds in nand_chip{}.
+ * @ecc.step_ds: The ECC step required by the @ecc.strength_ds, same as the
+ *               @ecc_step_ds in nand_chip{}, also from the datasheet.
+ *               For example, the "4bit ECC for each 512Byte" can be set with
+ *               NAND_ECC_INFO(4, 512).
  */
 struct nand_flash_dev {
 	char *name;
@@ -658,6 +669,10 @@ struct nand_flash_dev {
 	unsigned int options;
 	uint16_t id_len;
 	uint16_t oobsize;
+	struct {
+		uint16_t strength_ds;
+		uint16_t step_ds;
+	} ecc;
 };
 
 /**
-- 
1.7.1



  parent reply	other threads:[~2013-05-17  3:37 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-17  3:17 [PATCH v6 00/10] mtd: add datasheet's ECC information to nand_chip{} Huang Shijie
2013-05-17  3:17 ` [PATCH v6 01/10] " Huang Shijie
2013-05-17  3:17 ` [PATCH v6 02/10] mtd: get the ECC info from the parameter page for ONFI nand Huang Shijie
2013-05-17  3:17 ` [PATCH v6 03/10] mtd: add data structures for Extended Parameter Page Huang Shijie
2013-05-17  3:17 ` [PATCH v6 04/10] mtd: add a helper to get the supported features for ONFI nand Huang Shijie
2013-05-17  3:17 ` [PATCH v6 05/10] mtd: get the ECC info from the Extended Parameter Page Huang Shijie
2013-05-17 17:36   ` Vikram Narayanan
2013-05-20  2:08     ` [PATCH v6 05/10 fix] " Huang Shijie
2013-05-20  6:05       ` Brian Norris
     [not found]         ` <5199C159.6020401@freescale.com>
     [not found]           ` <CAHwEkO2Wn_jLCS-4-1p6Mks-0q3Dy_kzR-j-xtX_oOAOive2VQ@mail.gmail.com>
2013-05-22  2:15             ` Huang Shijie
2013-05-22  2:28         ` [PATCH v6 05/10 fix2] " Huang Shijie
2013-05-17  3:17 ` [PATCH v6 06/10] mtd: replace the hardcode with the onfi_feature() Huang Shijie
2013-05-17  3:17 ` Huang Shijie [this message]
2013-05-17  3:17 ` [PATCH v6 08/10] mtd: parse out the ECC info for the full-id nand chips Huang Shijie
2013-05-17  3:17 ` [PATCH v6 09/10] mtd: add the ecc info for some " Huang Shijie
2013-05-17  3:17 ` [PATCH v6 10/10] mtd: gpmi: set the BCH's geometry with the ecc info Huang Shijie
2013-06-25 20:12 ` [PATCH v6 00/10] mtd: add datasheet's ECC information to nand_chip{} Brian Norris
2013-08-08  8:33   ` Huang Shijie
2013-08-08 23:06     ` Brian Norris
2013-08-09  3:58       ` Artem Bityutskiy
2013-08-09  6:00         ` Brian Norris
2013-08-09  7:23           ` Artem Bityutskiy
2013-08-09  7:28             ` Brian Norris
2013-07-05  4:00 ` Huang Shijie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1368760654-28754-8-git-send-email-b32955@freescale.com \
    --to=b32955@freescale.com \
    --cc=computersforpeace@gmail.com \
    --cc=dedekind1@gmail.com \
    --cc=dwmw2@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=vikram186@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®