From: Artem Bityutskiy <dedekind1@gmail.com>
To: Brian Norris <computersforpeace@gmail.com>
Cc: Huang Shijie <b32955@freescale.com>,
dwmw2@infradead.org, linux-mtd@lists.infradead.org,
linux-kernel@vger.kernel.org, vikram186@gmail.com
Subject: Re: [PATCH v6 00/10] mtd: add datasheet's ECC information to nand_chip{}
Date: Fri, 09 Aug 2013 06:58:43 +0300 [thread overview]
Message-ID: <1376020723.2219.105.camel@sauron.fi.intel.com> (raw)
In-Reply-To: <20130808230630.GA14434@norris.computersforpeace.net>
On Thu, 2013-08-08 at 16:06 -0700, Brian Norris wrote:
> On Thu, Aug 08, 2013 at 04:33:35PM +0800, Huang Shijie wrote:
> > Hi Artem & Brian:
> > >Hi Huang and others,
> > >
> > >On Thu, May 16, 2013 at 8:17 PM, Huang Shijie<b32955@freescale.com> wrote:
> > >>1.) Why add the ECC information to the nand_chip{} ?
> ...
> > >Reviewed-by: Brian Norris<computersforpeace@gmail.com>
> > >Tested-by: Brian Norris<computersforpeace@gmail.com>
> > >
> > >Thanks for the work Huang.
> > >
> > Could you please merge this patch set?
>
> Thanks for the reminder. I haven't sorted through all the piles of
> backed up stuff yet!
>
> I made a few minor changes (for checkpatch.pl, regarding
> __attribute__((packed)), and to make the style a little more
> easily-read) and tested the generic stuff on my platform. I've pushed
> the series to l2-mtd.git. Thanks for the patience!
I guess you can try aiaiai, I run it for all the patches I take to
l2-mtd.git. It uses also coccinelle/smatch/sparse and other tools to
verify the patches, not only checkpatch. And this git tree contains
scripts and various defconfigs for various MTD drivers - the scripts run
aiaiai.
For example, to check Huang's patches, I run something like:
aiaiai-concat-mboxes ~/tmp/huang*.mbox | ./verify ../l2-mtd/ gpmi-nand
where "huang*.mbox" is Huang's patch set.
There are aliases for verious drivers. There is a 'gen' alias which I
use for general changes like changes in nand_base.c.
Read about the tool here:
http://git.infradead.org/users/dedekind/aiaiai.git/blob/HEAD:/doc/README.announcement
http://git.infradead.org/users/dedekind/aiaiai.git/blob/HEAD:/doc/README
The mtd maintenance helpers:
http://git.infradead.org/users/dedekind/maintaining.git
There are few minor issues in aiaiai, which I can fix if you hit them
and complain. Also, I did not invest much time in making the user
interface and experience very nice. But this can also be improved.
--
Best Regards,
Artem Bityutskiy
next prev parent reply other threads:[~2013-08-09 3:53 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-17 3:17 Huang Shijie
2013-05-17 3:17 ` [PATCH v6 01/10] " Huang Shijie
2013-05-17 3:17 ` [PATCH v6 02/10] mtd: get the ECC info from the parameter page for ONFI nand Huang Shijie
2013-05-17 3:17 ` [PATCH v6 03/10] mtd: add data structures for Extended Parameter Page Huang Shijie
2013-05-17 3:17 ` [PATCH v6 04/10] mtd: add a helper to get the supported features for ONFI nand Huang Shijie
2013-05-17 3:17 ` [PATCH v6 05/10] mtd: get the ECC info from the Extended Parameter Page Huang Shijie
2013-05-17 17:36 ` Vikram Narayanan
2013-05-20 2:08 ` [PATCH v6 05/10 fix] " Huang Shijie
2013-05-20 6:05 ` Brian Norris
[not found] ` <5199C159.6020401@freescale.com>
[not found] ` <CAHwEkO2Wn_jLCS-4-1p6Mks-0q3Dy_kzR-j-xtX_oOAOive2VQ@mail.gmail.com>
2013-05-22 2:15 ` Huang Shijie
2013-05-22 2:28 ` [PATCH v6 05/10 fix2] " Huang Shijie
2013-05-17 3:17 ` [PATCH v6 06/10] mtd: replace the hardcode with the onfi_feature() Huang Shijie
2013-05-17 3:17 ` [PATCH v6 07/10] mtd: add ECC info for nand_flash_dev{} Huang Shijie
2013-05-17 3:17 ` [PATCH v6 08/10] mtd: parse out the ECC info for the full-id nand chips Huang Shijie
2013-05-17 3:17 ` [PATCH v6 09/10] mtd: add the ecc info for some " Huang Shijie
2013-05-17 3:17 ` [PATCH v6 10/10] mtd: gpmi: set the BCH's geometry with the ecc info Huang Shijie
2013-06-25 20:12 ` [PATCH v6 00/10] mtd: add datasheet's ECC information to nand_chip{} Brian Norris
2013-08-08 8:33 ` Huang Shijie
2013-08-08 23:06 ` Brian Norris
2013-08-09 3:58 ` Artem Bityutskiy [this message]
2013-08-09 6:00 ` Brian Norris
2013-08-09 7:23 ` Artem Bityutskiy
2013-08-09 7:28 ` Brian Norris
2013-07-05 4:00 ` Huang Shijie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1376020723.2219.105.camel@sauron.fi.intel.com \
--to=dedekind1@gmail.com \
--cc=b32955@freescale.com \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=vikram186@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome