* [PATCH] dw_dmac: print message if IO resource is not found
@ 2013-05-17 11:47 Andy Shevchenko
2013-05-18 2:11 ` Viresh Kumar
0 siblings, 1 reply; 2+ messages in thread
From: Andy Shevchenko @ 2013-05-17 11:47 UTC (permalink / raw)
To: Viresh Kumar, Vinod Koul, linux-kernel, spear-devel; +Cc: Andy Shevchenko
devm_ioremap_resource() will print a message if resource is not found.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/dma/dw_dmac.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/dma/dw_dmac.c b/drivers/dma/dw_dmac.c
index 2e5deaa..29990b9 100644
--- a/drivers/dma/dw_dmac.c
+++ b/drivers/dma/dw_dmac.c
@@ -1667,14 +1667,11 @@ static int dw_probe(struct platform_device *pdev)
int err;
int i;
- io = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- if (!io)
- return -EINVAL;
-
irq = platform_get_irq(pdev, 0);
if (irq < 0)
return irq;
+ io = platform_get_resource(pdev, IORESOURCE_MEM, 0);
regs = devm_ioremap_resource(&pdev->dev, io);
if (IS_ERR(regs))
return PTR_ERR(regs);
--
1.8.2.rc0.22.gb3600c3
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] dw_dmac: print message if IO resource is not found
2013-05-17 11:47 [PATCH] dw_dmac: print message if IO resource is not found Andy Shevchenko
@ 2013-05-18 2:11 ` Viresh Kumar
0 siblings, 0 replies; 2+ messages in thread
From: Viresh Kumar @ 2013-05-18 2:11 UTC (permalink / raw)
To: Andy Shevchenko; +Cc: Vinod Koul, linux-kernel, spear-devel
On Fri, May 17, 2013 at 5:17 PM, Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
> devm_ioremap_resource() will print a message if resource is not found.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/dma/dw_dmac.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
Log and subject should be something like this.
https://patchwork.kernel.org/patch/2549091/
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-05-18 2:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-05-17 11:47 [PATCH] dw_dmac: print message if IO resource is not found Andy Shevchenko
2013-05-18 2:11 ` Viresh Kumar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome