* [PATCH] drivers/rtc/rtc-pl031.c: Pass correct pointer to free_irq()
@ 2013-05-20 15:41 Lars-Peter Clausen
2013-05-20 18:32 ` Linus Walleij
0 siblings, 1 reply; 2+ messages in thread
From: Lars-Peter Clausen @ 2013-05-20 15:41 UTC (permalink / raw)
To: Andrew Morton, Alessandro Zummo
Cc: Srinidhi Kasagar, Linus Walleij, rtc-linux, linux-kernel,
Lars-Peter Clausen
free_irq() expects the same pointer that was passed to request_irq(), otherwise
the IRQ is not freed.
The issue was found using the following coccinelle script:
<smpl>
@r1@
type T;
T devid;
@@
request_irq(..., devid)
@r2@
type r1.T;
T devid;
position p;
@@
free_irq@p(..., devid)
@@
position p != r2.p;
@@
*free_irq@p(...)
</smpl>
Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
---
drivers/rtc/rtc-pl031.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/rtc/rtc-pl031.c b/drivers/rtc/rtc-pl031.c
index 8900ea7..0f0609b 100644
--- a/drivers/rtc/rtc-pl031.c
+++ b/drivers/rtc/rtc-pl031.c
@@ -306,7 +306,7 @@ static int pl031_remove(struct amba_device *adev)
struct pl031_local *ldata = dev_get_drvdata(&adev->dev);
amba_set_drvdata(adev, NULL);
- free_irq(adev->irq[0], ldata->rtc);
+ free_irq(adev->irq[0], ldata);
rtc_device_unregister(ldata->rtc);
iounmap(ldata->base);
kfree(ldata);
--
1.8.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] drivers/rtc/rtc-pl031.c: Pass correct pointer to free_irq()
2013-05-20 15:41 [PATCH] drivers/rtc/rtc-pl031.c: Pass correct pointer to free_irq() Lars-Peter Clausen
@ 2013-05-20 18:32 ` Linus Walleij
0 siblings, 0 replies; 2+ messages in thread
From: Linus Walleij @ 2013-05-20 18:32 UTC (permalink / raw)
To: Lars-Peter Clausen
Cc: Andrew Morton, Alessandro Zummo, Srinidhi Kasagar, rtc-linux,
linux-kernel
On Mon, May 20, 2013 at 5:41 PM, Lars-Peter Clausen <lars@metafoo.de> wrote:
> free_irq() expects the same pointer that was passed to request_irq(), otherwise
> the IRQ is not freed.
>
> The issue was found using the following coccinelle script:
Good job!
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-05-20 18:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-05-20 15:41 [PATCH] drivers/rtc/rtc-pl031.c: Pass correct pointer to free_irq() Lars-Peter Clausen
2013-05-20 18:32 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®