mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Namhyung Kim <namhyung@kernel.org>
To: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@kernel.org>,
	Namhyung Kim <namhyung.kim@lge.com>,
	LKML <linux-kernel@vger.kernel.org>, Jiri Olsa <jolsa@redhat.com>,
	David Ahern <dsahern@gmail.com>,
	Stephane Eranian <eranian@google.com>,
	Pekka Enberg <penberg@kernel.org>
Subject: [RFC 0/7] perf report/gtk: Add support for hierarchy view
Date: Tue, 21 May 2013 15:14:31 +0900	[thread overview]
Message-ID: <1369116878-12489-1-git-send-email-namhyung@kernel.org> (raw)

Hi guys,

This patchset implements a new feature that collects hist entries in a
hierachical manner.  That means lower-level entries are belonged to an
upper-level entry.  The entry hierachy is built on the sort keys
given, so users can set it whatever they want.  It only shows
top-level entries first, and user can expand/collapse it dynamically.

This is only implemented in --gtk currently, since it's well-matched
to the GTK tree view widget and I didn't want to be bothered with the
TUI browser code at this stage. :)

I don't attach a screenshot now, but this is an hypothetical example
on stdio.  An usual output of perf report look like:

  Overhead  Command      Shared Object                                    Symbol
  ........  .......  .................  ........................................
    22.70%  swapper  [kernel.kallsyms]  [k] intel_idle
     8.36%  swapper  [kernel.kallsyms]  [k] irqtime_acouunt_process_tick.isra.74
     1.33%  swapper  [kernel.kallsyms]  [k] __schedule


If --hierarchy (-H) option is given, it'll look like (after expanding
all children):

  Overhead  Command / Shared Object / Symbol
  ........  ..............................................
    32.39%  - swapper
    32.39%    - [kernel.kallsyms]
    22.70%        [k] intel_idle
     8.36%        [k] irqtime_acouunt_process_tick.isra.74
     1.33%        [k] __schedule

(The overhead of an upper-level entry is the sum of lower-level
entries' overhead).

You can get it from 'perf/hierarchy-v1' branch on my tree at:

  git://git.kernel.org/pub/scm/linux/kernel/git/namhyung-perf.git


Any comments are welcome, thanks!
Namhyung


Namhyung Kim (7):
  perf hists: Basic support of hierarchical view
  perf gtk/hists: Use GtkTreeStore instead of GtkListStore
  perf gtk/hists: Factor out perf_gtk__add_entries()
  perf gtk/hists: Add support for hierachical output
  perf report: Add -H (--hierarchy) option
  perf gtk/hists: Add a double-click handler for hierarchy mode
  perf gtk/hists: Set rules hint for the hist browser

 tools/perf/Documentation/perf-report.txt |   5 +
 tools/perf/builtin-report.c              |   6 +
 tools/perf/ui/gtk/hists.c                | 192 ++++++++++++++----
 tools/perf/util/hist.c                   | 325 +++++++++++++++++++++++++++----
 tools/perf/util/sort.h                   |   3 +
 tools/perf/util/symbol.h                 |   3 +-
 6 files changed, 460 insertions(+), 74 deletions(-)

-- 
1.7.11.7


             reply	other threads:[~2013-05-21  6:14 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-21  6:14 Namhyung Kim [this message]
2013-05-21  6:14 ` [PATCH 1/7] perf hists: Basic support of hierarchical view Namhyung Kim
2013-05-21  6:14 ` [PATCH 2/7] perf gtk/hists: Use GtkTreeStore instead of GtkListStore Namhyung Kim
2013-05-21  6:14 ` [PATCH 3/7] perf gtk/hists: Factor out perf_gtk__add_entries() Namhyung Kim
2013-05-21  6:14 ` [PATCH 4/7] perf gtk/hists: Add support for hierachical output Namhyung Kim
2013-05-21  6:14 ` [PATCH 5/7] perf report: Add -H (--hierarchy) option Namhyung Kim
2013-05-21  6:14 ` [PATCH 6/7] perf gtk/hists: Add a double-click handler for hierarchy mode Namhyung Kim
2013-05-21  6:14 ` [PATCH 7/7] perf gtk/hists: Set rules hint for the hist browser Namhyung Kim
2013-05-21  7:04 ` [RFC 0/7] perf report/gtk: Add support for hierarchy view Pekka Enberg
2013-05-21  7:26   ` Namhyung Kim
2013-05-22  8:45     ` Pekka Enberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1369116878-12489-1-git-send-email-namhyung@kernel.org \
    --to=namhyung@kernel.org \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@ghostprotocols.net \
    --cc=dsahern@gmail.com \
    --cc=eranian@google.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=namhyung.kim@lge.com \
    --cc=paulus@samba.org \
    --cc=penberg@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®