From: Namhyung Kim <namhyung@kernel.org>
To: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@kernel.org>,
Namhyung Kim <namhyung.kim@lge.com>,
LKML <linux-kernel@vger.kernel.org>, Jiri Olsa <jolsa@redhat.com>,
David Ahern <dsahern@gmail.com>,
Stephane Eranian <eranian@google.com>,
Pekka Enberg <penberg@kernel.org>
Subject: [PATCH 5/7] perf report: Add -H (--hierarchy) option
Date: Tue, 21 May 2013 15:14:36 +0900 [thread overview]
Message-ID: <1369116878-12489-6-git-send-email-namhyung@kernel.org> (raw)
In-Reply-To: <1369116878-12489-1-git-send-email-namhyung@kernel.org>
From: Namhyung Kim <namhyung.kim@lge.com>
It's for enabling the hierarchical view.
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
---
tools/perf/Documentation/perf-report.txt | 5 +++++
tools/perf/builtin-report.c | 6 ++++++
2 files changed, 11 insertions(+)
diff --git a/tools/perf/Documentation/perf-report.txt b/tools/perf/Documentation/perf-report.txt
index 7d5f4f38aa52..3c86b9f83c54 100644
--- a/tools/perf/Documentation/perf-report.txt
+++ b/tools/perf/Documentation/perf-report.txt
@@ -210,6 +210,11 @@ OPTIONS
Demangle symbol names to human readable form. It's enabled by default,
disable with --no-demangle.
+-H::
+--hierarchy::
+ Show events in hierarchical view. Each events are grouped under prior
+ sort keys. Currently --gtk output is supported only.
+
SEE ALSO
--------
linkperf:perf-stat[1], linkperf:perf-annotate[1]
diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
index d45bf9b0361d..9b9a35b296d8 100644
--- a/tools/perf/builtin-report.c
+++ b/tools/perf/builtin-report.c
@@ -809,6 +809,7 @@ int cmd_report(int argc, const char **argv, const char *prefix __maybe_unused)
OPT_BOOLEAN(0, "demangle", &symbol_conf.demangle,
"Disable symbol demangling"),
OPT_BOOLEAN(0, "mem-mode", &report.mem_mode, "mem access profile"),
+ OPT_BOOLEAN('H', "hierarchy", &symbol_conf.hierarchy, "Hierarchical view"),
OPT_END()
};
@@ -833,6 +834,11 @@ int cmd_report(int argc, const char **argv, const char *prefix __maybe_unused)
input_name = "perf.data";
}
+ if (symbol_conf.hierarchy && use_browser != 2) {
+ pr_err("--hierarchy option is only used for --gtk output\n");
+ return -EINVAL;
+ }
+
if (strcmp(input_name, "-") != 0)
setup_browser(true);
else {
--
1.7.11.7
next prev parent reply other threads:[~2013-05-21 6:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-21 6:14 [RFC 0/7] perf report/gtk: Add support for hierarchy view Namhyung Kim
2013-05-21 6:14 ` [PATCH 1/7] perf hists: Basic support of hierarchical view Namhyung Kim
2013-05-21 6:14 ` [PATCH 2/7] perf gtk/hists: Use GtkTreeStore instead of GtkListStore Namhyung Kim
2013-05-21 6:14 ` [PATCH 3/7] perf gtk/hists: Factor out perf_gtk__add_entries() Namhyung Kim
2013-05-21 6:14 ` [PATCH 4/7] perf gtk/hists: Add support for hierachical output Namhyung Kim
2013-05-21 6:14 ` Namhyung Kim [this message]
2013-05-21 6:14 ` [PATCH 6/7] perf gtk/hists: Add a double-click handler for hierarchy mode Namhyung Kim
2013-05-21 6:14 ` [PATCH 7/7] perf gtk/hists: Set rules hint for the hist browser Namhyung Kim
2013-05-21 7:04 ` [RFC 0/7] perf report/gtk: Add support for hierarchy view Pekka Enberg
2013-05-21 7:26 ` Namhyung Kim
2013-05-22 8:45 ` Pekka Enberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1369116878-12489-6-git-send-email-namhyung@kernel.org \
--to=namhyung@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=dsahern@gmail.com \
--cc=eranian@google.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung.kim@lge.com \
--cc=paulus@samba.org \
--cc=penberg@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®