Re: [PATCH 0/5] perf: net_dropmonitor: Make it work and make it fast

[Ben Hutchings <ben@decadent.org.uk>]

[-- Attachment #1: Type: text/plain, Size: 1224 bytes --]

On Tue, 2013-05-21 at 09:33 -0400, Neil Horman wrote:
> On Tue, May 21, 2013 at 01:42:56AM +0100, Ben Hutchings wrote:
> > Somewhat surprisingly, the net_dropmonitor reporting script doesn't work
> > at all.  This series fixes it and then makes it slightly more efficient.
> > 
> > Ben.
> > 
> It worked fine when I first submitted it.  I wonder if there was a paramter
> order change at some point that I wasn't CC'ed on.

The parameter order for the trace event changed in 2.6.39, but that was
before this script went in.

Ben.

> Either way, this all looks good.  Thanks Ben.
> 
> Acked-by: Neil Horman <nhorman@tuxdriver.com>
> 
> > Ben Hutchings (5):
> >   perf: net_dropmonitor: Fix trace parameter order
> >   perf: net_dropmonitor: Fix symbol-relative addresses
> >   perf: net_dropmonitor: Do not assume ordering of dictionaries
> >   perf: net_dropmonitor: Use bisection in symbol lookup
> >   perf: net_dropmonitor: Remove progress indicator
> > 
> >  tools/perf/scripts/python/net_dropmonitor.py |   39 ++++++++++++++------------
> >  1 file changed, 21 insertions(+), 18 deletions(-)
> > 
> > 
> 
> 

-- 
Ben Hutchings
friends: People who know you well, but like you anyway.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]