mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] tracing: code cleanup
@ 2013-05-24  7:22 Harsh Prateek Bora
  2013-05-24 13:26 ` Steven Rostedt
  0 siblings, 1 reply; 2+ messages in thread
From: Harsh Prateek Bora @ 2013-05-24  7:22 UTC (permalink / raw)
  To: linux-kernel, rostedt; +Cc: srikar, Harsh Prateek Bora


Signed-off-by: Harsh Prateek Bora <harsh@linux.vnet.ibm.com>
---
 kernel/trace/trace_events.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/kernel/trace/trace_events.c b/kernel/trace/trace_events.c
index 7a0cf68..371c7b0 100644
--- a/kernel/trace/trace_events.c
+++ b/kernel/trace/trace_events.c
@@ -2011,10 +2011,7 @@ event_enable_func(struct ftrace_hash *hash,
 	int ret;
 
 	/* hash funcs only work with set_ftrace_filter */
-	if (!enabled)
-		return -EINVAL;
-
-	if (!param)
+	if (!enabled || !param)
 		return -EINVAL;
 
 	system = strsep(&param, ":");
-- 
1.7.11.7


^ permalink raw reply	[flat|nested] 2+ messages in thread
* Re: [PATCH] tracing: code cleanup
  2013-05-24  7:22 [PATCH] tracing: code cleanup Harsh Prateek Bora
@ 2013-05-24 13:26 ` Steven Rostedt
  0 siblings, 0 replies; 2+ messages in thread
From: Steven Rostedt @ 2013-05-24 13:26 UTC (permalink / raw)
  To: Harsh Prateek Bora; +Cc: linux-kernel, srikar

On Fri, 2013-05-24 at 12:52 +0530, Harsh Prateek Bora wrote:
> Signed-off-by: Harsh Prateek Bora <harsh@linux.vnet.ibm.com>
> ---
>  kernel/trace/trace_events.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/kernel/trace/trace_events.c b/kernel/trace/trace_events.c
> index 7a0cf68..371c7b0 100644
> --- a/kernel/trace/trace_events.c
> +++ b/kernel/trace/trace_events.c
> @@ -2011,10 +2011,7 @@ event_enable_func(struct ftrace_hash *hash,
>  	int ret;
>  
>  	/* hash funcs only work with set_ftrace_filter */
> -	if (!enabled)
> -		return -EINVAL;
> -
> -	if (!param)
> +	if (!enabled || !param)
>  		return -EINVAL;
>  
>  	system = strsep(&param, ":");


Thanks, I added it to my 3.11 queue.

-- Steve



^ permalink raw reply	[flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-05-24 13:26 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-05-24  7:22 [PATCH] tracing: code cleanup Harsh Prateek Bora
2013-05-24 13:26 ` Steven Rostedt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®