From: Phil Carmody <phil.carmody@partner.samsung.com>
To: apw@canonical.com, joe@perches.com
Cc: linux-kernel@vger.kernel.org,
Phil Carmody <phil.carmody@partner.samsung.com>
Subject: [PATCH] checkpatch: forgive use of mixed case variables measuring units
Date: Wed, 29 May 2013 14:02:50 +0300 [thread overview]
Message-ID: <1369825370-31901-1-git-send-email-phil.carmody@partner.samsung.com> (raw)
I don't think anyone really has an issue with things like max_mV.
And whilst nS et al. may not be SI standard, at least it's clear
what they represent.
Signed-off-by: Phil Carmody <phil.carmody@partner.samsung.com>
---
scripts/checkpatch.pl | 1 +
1 file changed, 1 insertion(+)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index b954de5..c29fd2f 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -2940,6 +2940,7 @@ sub process {
if ($var !~ /$Constant/ &&
$var =~ /[A-Z]\w*[a-z]|[a-z]\w*[A-Z]/ &&
$var !~ /"^(?:Clear|Set|TestClear|TestSet|)Page[A-Z]/ &&
+ $var !~ /^[a-z_]*_[numk][VAS]$/ &&
!defined $camelcase{$var}) {
$camelcase{$var} = 1;
WARN("CAMELCASE",
--
1.7.9.5
next reply other threads:[~2013-05-29 11:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-29 11:02 Phil Carmody [this message]
2013-05-29 11:24 ` Joe Perches
2013-06-12 12:59 ` Phil Carmody
2013-06-12 16:02 ` Joe Perches
2013-06-12 16:17 ` Jason Cooper
2013-06-12 16:26 ` Joe Perches
2013-06-12 16:21 ` [PATCH] checkpatch: CamelCase - ignore SI unit variants like "_uV" Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1369825370-31901-1-git-send-email-phil.carmody@partner.samsung.com \
--to=phil.carmody@partner.samsung.com \
--cc=apw@canonical.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®