From: Jason Cooper <jason@lakedaemon.net>
To: Joe Perches <joe@perches.com>
Cc: Phil Carmody <phil.carmody@partner.samsung.com>,
apw@canonical.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] checkpatch: forgive use of mixed case variables measuring units
Date: Wed, 12 Jun 2013 12:17:58 -0400 [thread overview]
Message-ID: <20130612161758.GU23859@titan.lakedaemon.net> (raw)
In-Reply-To: <1371052935.2069.14.camel@joe-AO722>
On Wed, Jun 12, 2013 at 09:02:15AM -0700, Joe Perches wrote:
> On Wed, 2013-06-12 at 15:59 +0300, Phil Carmody wrote:
> > I agree that a creeping list of exceptions where CamelCase
> > is to be overlooked would be bad, but I would argue that
> > perhaps my exceptions aren't actual CamelCase - they're
> > (pretending to be) SI units, and just happen to match the
> > CamelCase regexp. I did a grep for my regexp, and everything
> > I noticed in a quick scan did look like a justifiable
> > variable name.
>
> Maybe, but this regex misses variants like:
>
> regulator_min_uA_show
>
> Maybe "^[a-z_]*_[numk][VAS](?:_\w+)?$"
>
> But this regex also does not match on other common
> sound variants "_dB", "_mB" and temperature like "_mC".
And _dBm ...
thx,
Jason.
next prev parent reply other threads:[~2013-06-12 16:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-29 11:02 Phil Carmody
2013-05-29 11:24 ` Joe Perches
2013-06-12 12:59 ` Phil Carmody
2013-06-12 16:02 ` Joe Perches
2013-06-12 16:17 ` Jason Cooper [this message]
2013-06-12 16:26 ` Joe Perches
2013-06-12 16:21 ` [PATCH] checkpatch: CamelCase - ignore SI unit variants like "_uV" Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130612161758.GU23859@titan.lakedaemon.net \
--to=jason@lakedaemon.net \
--cc=apw@canonical.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=phil.carmody@partner.samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®