* [PATCH 7/7] tulip: remove redundant D0 power state set
@ 2013-05-30 10:27 Yijing Wang
2013-05-30 15:31 ` Grant Grundler
0 siblings, 1 reply; 3+ messages in thread
From: Yijing Wang @ 2013-05-30 10:27 UTC (permalink / raw)
To: Grant Grundler; +Cc: linux-kernel, netdev, Hanjun Guo, Jiang Liu, Yijing Wang
Pci_enable_device() will set device power state to D0,
so it's no need to do it again in tulip_init_one().
Signed-off-by: Yijing Wang <wangyijing@huawei.com>
---
drivers/net/ethernet/dec/tulip/tulip_core.c | 6 ------
1 files changed, 0 insertions(+), 6 deletions(-)
diff --git a/drivers/net/ethernet/dec/tulip/tulip_core.c b/drivers/net/ethernet/dec/tulip/tulip_core.c
index 1e9443d..c94152f 100644
--- a/drivers/net/ethernet/dec/tulip/tulip_core.c
+++ b/drivers/net/ethernet/dec/tulip/tulip_core.c
@@ -1410,12 +1410,6 @@ static int tulip_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
return i;
}
- /* The chip will fail to enter a low-power state later unless
- * first explicitly commanded into D0 */
- if (pci_set_power_state(pdev, PCI_D0)) {
- pr_notice("Failed to set power state to D0\n");
- }
-
irq = pdev->irq;
/* alloc_etherdev ensures aligned and zeroed private structures */
--
1.7.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 7/7] tulip: remove redundant D0 power state set
2013-05-30 10:27 [PATCH 7/7] tulip: remove redundant D0 power state set Yijing Wang
@ 2013-05-30 15:31 ` Grant Grundler
2013-05-31 8:39 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Grant Grundler @ 2013-05-30 15:31 UTC (permalink / raw)
To: Yijing Wang; +Cc: Grant Grundler, Hanjun Guo, Jiang Liu, LKML, NetDev
On Thu, May 30, 2013 at 3:27 AM, Yijing Wang <wangyijing@huawei.com> wrote:
> Pci_enable_device() will set device power state to D0,
> so it's no need to do it again in tulip_init_one().
>
> Signed-off-by: Yijing Wang <wangyijing@huawei.com>
Ack-by: Grant Grundler <grundler@parisc-linux.org>
thanks!
grant
> ---
> drivers/net/ethernet/dec/tulip/tulip_core.c | 6 ------
> 1 files changed, 0 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/net/ethernet/dec/tulip/tulip_core.c b/drivers/net/ethernet/dec/tulip/tulip_core.c
> index 1e9443d..c94152f 100644
> --- a/drivers/net/ethernet/dec/tulip/tulip_core.c
> +++ b/drivers/net/ethernet/dec/tulip/tulip_core.c
> @@ -1410,12 +1410,6 @@ static int tulip_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
> return i;
> }
>
> - /* The chip will fail to enter a low-power state later unless
> - * first explicitly commanded into D0 */
> - if (pci_set_power_state(pdev, PCI_D0)) {
> - pr_notice("Failed to set power state to D0\n");
> - }
> -
> irq = pdev->irq;
>
> /* alloc_etherdev ensures aligned and zeroed private structures */
> --
> 1.7.1
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 7/7] tulip: remove redundant D0 power state set
2013-05-30 15:31 ` Grant Grundler
@ 2013-05-31 8:39 ` David Miller
0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2013-05-31 8:39 UTC (permalink / raw)
To: grantgrundler
Cc: wangyijing, grundler, guohanjun, liuj97, linux-kernel, netdev
From: Grant Grundler <grantgrundler@gmail.com>
Date: Thu, 30 May 2013 08:31:38 -0700
> On Thu, May 30, 2013 at 3:27 AM, Yijing Wang <wangyijing@huawei.com> wrote:
>> Pci_enable_device() will set device power state to D0,
>> so it's no need to do it again in tulip_init_one().
>>
>> Signed-off-by: Yijing Wang <wangyijing@huawei.com>
>
> Ack-by: Grant Grundler <grundler@parisc-linux.org>
(it's Acked-by) Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-05-31 8:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-05-30 10:27 [PATCH 7/7] tulip: remove redundant D0 power state set Yijing Wang
2013-05-30 15:31 ` Grant Grundler
2013-05-31 8:39 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®