From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Kefeng Wang <wangkefeng.wang@huawei.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
guohanjun@huawei.com
Subject: Re: [PATCH 0/5] scsi: use platform helper macro and wrapper functions
Date: Thu, 30 May 2013 07:38:19 -0700 [thread overview]
Message-ID: <1369924699.1972.4.camel@dabdike.int.hansenpartnership.com> (raw)
In-Reply-To: <1369915786-2660-1-git-send-email-wangkefeng.wang@huawei.com>
On Thu, 2013-05-30 at 20:09 +0800, Kefeng Wang wrote:
> use module_platform_driver() and paltform{set,get}_drvdata to simpily code,
> and patch 2/5 delete unnecessery drvdate set to null.
>
> Kefeng Wang (5):
> scsi: jazz: use module_platform_driver() and
> platform_{set,get}_drvdata
> scsi: sun: use module_platform_driver() and platform_{set,get}_drvdata
> scsi: qlogicpti: use module_platform_driver() and
> platform_{set,get}_drvdata
> scsi: sun3x: use module_platform_driver() and
> platform_{set,get}_drvdata
> scsi: sni: use module_platform_driver() and platform_{set,get}_drvdata
>
> drivers/scsi/jazz_esp.c | 17 +++--------------
> drivers/scsi/qlogicpti.c | 17 +++--------------
> drivers/scsi/sni_53c710.c | 17 +++--------------
> drivers/scsi/sun3x_esp.c | 16 +++-------------
> drivers/scsi/sun_esp.c | 19 +++----------------
> 5 files changed, 15 insertions(+), 71 deletions(-)
There doesn't seem to be much point to these patches since either idiom
is fine and easily understood. We also try to touch the ancient drivers
as little as possible since it can be months before anyone actually
tries them out and notices that something got broken, so the rule for
them is obvious bug fixes only.
James
next prev parent reply other threads:[~2013-05-30 14:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-30 12:09 Kefeng Wang
2013-05-30 12:09 ` [PATCH 1/5] scsi: jazz: use module_platform_driver() and platform_{set,get}_drvdata Kefeng Wang
2013-05-30 12:09 ` [PATCH 2/5] scsi: sun: " Kefeng Wang
2013-05-30 12:09 ` [PATCH 3/5] scsi: qlogicpti: " Kefeng Wang
2013-05-30 12:09 ` [PATCH 4/5] scsi: sun3x: " Kefeng Wang
2013-05-30 12:09 ` [PATCH 5/5] scsi: sni: " Kefeng Wang
2013-05-30 14:38 ` James Bottomley [this message]
2013-05-31 1:15 ` [PATCH 0/5] scsi: use platform helper macro and wrapper functions Kefeng Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1369924699.1972.4.camel@dabdike.int.hansenpartnership.com \
--to=james.bottomley@hansenpartnership.com \
--cc=davem@davemloft.net \
--cc=guohanjun@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=tsbogend@alpha.franken.de \
--cc=wangkefeng.wang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®