From: Marcus Overhagen <marcus.overhagen@gmail.com>
To: LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH 1/1] Fix SD card detection and use correct transfer interval.
Date: Sat, 1 Jun 2013 18:22:11 +0200 [thread overview]
Message-ID: <1370103731-5667-2-git-send-email-marcus.overhagen@gmail.com> (raw)
In-Reply-To: <1370103731-5667-1-git-send-email-marcus.overhagen@gmail.com>
Increasing the timeout when polling for card status to 100ms
as used at other places in this driver fixes SD card detection.
Also use correct interval when doing the interrupt transfer,
this fixes the "xhci_queue_intr_tx: 74 callbacks suppressed"
spamming to syslog that was occuring when this driver is used.
Signed-off-by: Marcus Overhagen <marcus.overhagen@gmail.com>
---
drivers/staging/rts5139/rts51x_transport.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rts5139/rts51x_transport.c b/drivers/staging/rts5139/rts51x_transport.c
index 89e4d80..c172f4a 100644
--- a/drivers/staging/rts5139/rts51x_transport.c
+++ b/drivers/staging/rts5139/rts51x_transport.c
@@ -635,12 +635,12 @@ int rts51x_get_epc_status(struct rts51x_chip *chip, u16 *status)
ep = chip->usb->pusb_dev->ep_in[usb_pipeendpoint(pipe)];
/* fill and submit the URB */
- /* We set interval to 1 here, so the polling interval is controlled
- * by our polling thread */
+ /* Set interval to 10 here to match the endpoint descriptor,
+ * the polling interval is controlled by the polling thread */
usb_fill_int_urb(chip->usb->intr_urb, chip->usb->pusb_dev, pipe,
- status, 2, urb_done_completion, &urb_done, 1);
+ status, 2, urb_done_completion, &urb_done, 10);
- result = rts51x_msg_common(chip, chip->usb->intr_urb, 50);
+ result = rts51x_msg_common(chip, chip->usb->intr_urb, 100);
return interpret_urb_result(chip, pipe, 2, result,
chip->usb->intr_urb->actual_length);
--
1.8.1.2
next prev parent reply other threads:[~2013-06-01 16:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-01 16:22 [PATCH 0/1] rts5139 " Marcus Overhagen
2013-06-01 16:22 ` Marcus Overhagen [this message]
2013-10-05 12:06 ` [PATCH 1/1] " Simon Easter
2013-11-05 20:01 ` Andreas Mohr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1370103731-5667-2-git-send-email-marcus.overhagen@gmail.com \
--to=marcus.overhagen@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®