* [PATCH v2 1/2] staging: gdm72xx: WIMAX_GDM72XX should depend on either USB or MMC
@ 2013-06-04 5:55 Ben Chan
2013-06-04 5:55 ` [PATCH v2 2/2] staging: gdm72xx: fix typos in Kconfig Ben Chan
0 siblings, 1 reply; 2+ messages in thread
From: Ben Chan @ 2013-06-04 5:55 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: devel, linux-kernel, Ben Chan, Sage Ahn
The gdm72xx driver needs to have either the USB or SDIO implementation
enabled to provide useful functionalities, so the driver should depend
on either USB or MMC. This patch makes WIMAX_GDM72XX depend on either
USB or MMC.
Also, WIMAX_GDM72XX needs to be built as a module if its dependent
interface, either USB or MMC, is built as a module. This patch enforces
that in the WIMAX_GDM72XX_USB and WIMAX_GDM72XX_SDIO dependency.
Reported-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Ben Chan <benchan@chromium.org>
Cc: Sage Ahn <syahn@gctsemi.com>
---
drivers/staging/gdm72xx/Kconfig | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/gdm72xx/Kconfig b/drivers/staging/gdm72xx/Kconfig
index 6905913..dd47bd1 100644
--- a/drivers/staging/gdm72xx/Kconfig
+++ b/drivers/staging/gdm72xx/Kconfig
@@ -4,7 +4,7 @@
menuconfig WIMAX_GDM72XX
tristate "GCT GDM72xx WiMAX support"
- depends on NET
+ depends on NET && (USB || MMC)
help
Support for the GCT GDM72xx WiMAX chip
@@ -27,11 +27,11 @@ choice
config WIMAX_GDM72XX_USB
bool "USB interface"
- depends on USB
+ depends on (USB = y || USB = WIMAX_GDM72XX)
config WIMAX_GDM72XX_SDIO
bool "SDIO interface"
- depends on MMC
+ depends on (MMC = y || MMC = WIMAX_GDM72XX)
endchoice
--
1.8.2.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH v2 2/2] staging: gdm72xx: fix typos in Kconfig
2013-06-04 5:55 [PATCH v2 1/2] staging: gdm72xx: WIMAX_GDM72XX should depend on either USB or MMC Ben Chan
@ 2013-06-04 5:55 ` Ben Chan
0 siblings, 0 replies; 2+ messages in thread
From: Ben Chan @ 2013-06-04 5:55 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: devel, linux-kernel, Ben Chan, Sage Ahn
Signed-off-by: Ben Chan <benchan@chromium.org>
Cc: Sage Ahn <syahn@gctsemi.com>
---
drivers/staging/gdm72xx/Kconfig | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/gdm72xx/Kconfig b/drivers/staging/gdm72xx/Kconfig
index dd47bd1..dd8a391 100644
--- a/drivers/staging/gdm72xx/Kconfig
+++ b/drivers/staging/gdm72xx/Kconfig
@@ -19,7 +19,7 @@ config WIMAX_GDM72XX_K_MODE
default n
config WIMAX_GDM72XX_WIMAX2
- bool "Enable WIMAX2 support"
+ bool "Enable WiMAX2 support"
default n
choice
@@ -38,7 +38,7 @@ endchoice
if WIMAX_GDM72XX_USB
config WIMAX_GDM72XX_USB_PM
- bool "Enable power managerment support"
+ bool "Enable power management support"
depends on PM_RUNTIME
endif # WIMAX_GDM72XX_USB
--
1.8.2.1
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-06-04 5:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-06-04 5:55 [PATCH v2 1/2] staging: gdm72xx: WIMAX_GDM72XX should depend on either USB or MMC Ben Chan
2013-06-04 5:55 ` [PATCH v2 2/2] staging: gdm72xx: fix typos in Kconfig Ben Chan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®