* [RESEND][PATCH 3/7] net, ipw2x00: remove redundant D0 power state set
@ 2013-06-04 7:07 Yijing Wang
2013-06-04 9:16 ` Stanislav Yakovlev
0 siblings, 1 reply; 2+ messages in thread
From: Yijing Wang @ 2013-06-04 7:07 UTC (permalink / raw)
To: David S. Miller
Cc: linux-kernel, netdev, Yijing Wang, Stanislav Yakovlev,
John W. Linville, linux-wireless
Pci_enable_device() will set device power state to D0,
so it's no need to do it again in ipw2100_pci_init_one().
Signed-off-by: Yijing Wang <wangyijing@huawei.com>
Cc: Stanislav Yakovlev <stas.yakovlev@gmail.com>
Cc: "John W. Linville" <linville@tuxdriver.com>
Cc: netdev@vger.kernel.org
Cc: linux-wireless@vger.kernel.org
---
drivers/net/wireless/ipw2x00/ipw2100.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/ipw2x00/ipw2100.c b/drivers/net/wireless/ipw2x00/ipw2100.c
index 15920aa..f8ab193 100644
--- a/drivers/net/wireless/ipw2x00/ipw2100.c
+++ b/drivers/net/wireless/ipw2x00/ipw2100.c
@@ -6242,8 +6242,6 @@ static int ipw2100_pci_init_one(struct pci_dev *pci_dev,
if ((val & 0x0000ff00) != 0)
pci_write_config_dword(pci_dev, 0x40, val & 0xffff00ff);
- pci_set_power_state(pci_dev, PCI_D0);
-
if (!ipw2100_hw_is_adapter_in_system(dev)) {
printk(KERN_WARNING DRV_NAME
"Device not found via register read.\n");
--
1.7.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [RESEND][PATCH 3/7] net, ipw2x00: remove redundant D0 power state set
2013-06-04 7:07 [RESEND][PATCH 3/7] net, ipw2x00: remove redundant D0 power state set Yijing Wang
@ 2013-06-04 9:16 ` Stanislav Yakovlev
0 siblings, 0 replies; 2+ messages in thread
From: Stanislav Yakovlev @ 2013-06-04 9:16 UTC (permalink / raw)
To: Yijing Wang
Cc: David S. Miller, linux-kernel, netdev, John W. Linville, linux-wireless
Hi Yijing,
On 4 June 2013 00:07, Yijing Wang <wangyijing@huawei.com> wrote:
> Pci_enable_device() will set device power state to D0,
> so it's no need to do it again in ipw2100_pci_init_one().
>
> Signed-off-by: Yijing Wang <wangyijing@huawei.com>
> Cc: Stanislav Yakovlev <stas.yakovlev@gmail.com>
> Cc: "John W. Linville" <linville@tuxdriver.com>
> Cc: netdev@vger.kernel.org
> Cc: linux-wireless@vger.kernel.org
Looks fine, thanks.
Stanislav.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-06-04 9:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-06-04 7:07 [RESEND][PATCH 3/7] net, ipw2x00: remove redundant D0 power state set Yijing Wang
2013-06-04 9:16 ` Stanislav Yakovlev
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®