mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Christian Ruppert <christian.ruppert@abilis.com>
To: Wolfram Sang <wsa@the-dreams.de>,
	Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: Jean Delvare <khali@linux-fr.org>,
	Pierrick Hascoet <pierrick.hascoet@abilis.com>,
	Christian Ruppert <christian.ruppert@abilis.com>,
	linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 2/2] i2c: designware: make i2c xfers non-interruptible
Date: Thu,  6 Jun 2013 15:43:36 +0200	[thread overview]
Message-ID: <1370526216-10060-2-git-send-email-christian.ruppert@abilis.com> (raw)
In-Reply-To: <1370526216-10060-1-git-send-email-christian.ruppert@abilis.com>

When the process at the source of an i2c transfer is killed in the
middle of the transfer, the transfer is interrupted. Interrupted
transfers might cause buggy slaves on the bus (or higher level drivers)
to go haywire.
This patch forces ongoing i2c transfers to finish properly, even if the
initiating process is killed.

Signed-off-by: Christian Ruppert <christian.ruppert@abilis.com>
---
 drivers/i2c/busses/i2c-designware-core.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/i2c/busses/i2c-designware-core.c b/drivers/i2c/busses/i2c-designware-core.c
index 65c0c7a..d903368 100644
--- a/drivers/i2c/busses/i2c-designware-core.c
+++ b/drivers/i2c/busses/i2c-designware-core.c
@@ -585,7 +585,7 @@ i2c_dw_xfer(struct i2c_adapter *adap, struct i2c_msg msgs[], int num)
 	i2c_dw_xfer_init(dev);
 
 	/* wait for tx to complete */
-	ret = wait_for_completion_interruptible_timeout(&dev->cmd_complete, HZ);
+	ret = wait_for_completion_timeout(&dev->cmd_complete, HZ);
 	if (ret == 0) {
 		dev_err(dev->dev, "controller timed out\n");
 		/* i2c_dw_init implicitly disables the adapter */
-- 
1.7.1


  reply	other threads:[~2013-06-06 13:44 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-06 13:43 [PATCH 1/2] i2c: designware: fix race between subsequent xfers Christian Ruppert
2013-06-06 13:43 ` Christian Ruppert [this message]
2013-06-07  5:25   ` [PATCH 2/2] i2c: designware: make i2c xfers non-interruptible Mika Westerberg
2013-06-07  7:55     ` Christian Ruppert
2013-06-07  5:23 ` [PATCH 1/2] i2c: designware: fix race between subsequent xfers Mika Westerberg
2013-06-07  8:16   ` Christian Ruppert
2013-06-07  8:51 ` [PATCH V2] " Christian Ruppert
2013-06-07  9:19   ` Andy Shevchenko
2013-06-14 14:37   ` Wolfram Sang
2013-06-17  8:19     ` Christian Ruppert
2013-06-17  8:33       ` Jean Delvare
2013-06-17  9:01         ` Christian Ruppert
2013-06-17  8:34     ` Mika Westerberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1370526216-10060-2-git-send-email-christian.ruppert@abilis.com \
    --to=christian.ruppert@abilis.com \
    --cc=khali@linux-fr.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mika.westerberg@linux.intel.com \
    --cc=pierrick.hascoet@abilis.com \
    --cc=wsa@the-dreams.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®