From: Christian Ruppert <christian.ruppert@abilis.com>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: Mika Westerberg <mika.westerberg@linux.intel.com>,
Jean Delvare <khali@linux-fr.org>,
Pierrick Hascoet <pierrick.hascoet@abilis.com>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2] i2c: designware: fix race between subsequent xfers
Date: Mon, 17 Jun 2013 10:19:33 +0200 [thread overview]
Message-ID: <20130617081931.GB19380@ab42.lan> (raw)
In-Reply-To: <20130614143740.GD2929@katana>
On Fri, Jun 14, 2013 at 04:37:41PM +0200, Wolfram Sang wrote:
> On Fri, Jun 07, 2013 at 10:51:23AM +0200, Christian Ruppert wrote:
> [...]
> > + /*
> > + * We must disable the adapter before unlocking the &dev->lock mutex
> > + * below. Otherwise the hardware might continue generating interrupts
> > + * which in turn causes a race condition with the following transfer.
>
> I added "Needs some more investigation if the additional interrupts are
> a hardware bug or this driver doesn't handle them correctly yet." to the
> comment and
Good idea, thanks.
> Applied to for-next, thanks!
>
> BTW since I am currently here: i2c-designware-core should be in the
> 'algos' directory, no?
At the risk of passing for a complete moron: What exactly is the
difference between I2C algos and I2C bus drivers?
Greetings,
Christian
--
Christian Ruppert , <christian.ruppert@abilis.com>
/|
Tel: +41/(0)22 816 19-42 //| 3, Chemin du Pré-Fleuri
_// | bilis Systems CH-1228 Plan-les-Ouates
next prev parent reply other threads:[~2013-06-17 8:20 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-06 13:43 [PATCH 1/2] " Christian Ruppert
2013-06-06 13:43 ` [PATCH 2/2] i2c: designware: make i2c xfers non-interruptible Christian Ruppert
2013-06-07 5:25 ` Mika Westerberg
2013-06-07 7:55 ` Christian Ruppert
2013-06-07 5:23 ` [PATCH 1/2] i2c: designware: fix race between subsequent xfers Mika Westerberg
2013-06-07 8:16 ` Christian Ruppert
2013-06-07 8:51 ` [PATCH V2] " Christian Ruppert
2013-06-07 9:19 ` Andy Shevchenko
2013-06-14 14:37 ` Wolfram Sang
2013-06-17 8:19 ` Christian Ruppert [this message]
2013-06-17 8:33 ` Jean Delvare
2013-06-17 9:01 ` Christian Ruppert
2013-06-17 8:34 ` Mika Westerberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130617081931.GB19380@ab42.lan \
--to=christian.ruppert@abilis.com \
--cc=khali@linux-fr.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=pierrick.hascoet@abilis.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®