From: Joe Perches <joe@perches.com>
To: Lorenz Haspel <lorenz@badgers.com>
Cc: devel@linuxdriverproject.org, gregkh@linuxfoundation.org,
puff65537@bansheeslibrary.com, viro@zeniv.linux.org.uk,
michael.banken@mathe.stud.uni-erlangen.de,
dan.carpenter@oracle.com, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org,
linux-kernel@i4.informatik.uni-erlangen.de
Subject: Re: [PATCH 4/4] solicom: checkpatch: added parenthesis to macros
Date: Mon, 17 Jun 2013 09:35:21 -0700 [thread overview]
Message-ID: <1371486921.2213.1.camel@joe-AO722> (raw)
In-Reply-To: <1371486386-8043-4-git-send-email-lorenz@badgers.com>
On Mon, 2013-06-17 at 18:26 +0200, Lorenz Haspel wrote:
> fixed checkpatch error:
> added parenthesis around complex macros.
[]
> diff --git a/drivers/staging/silicom/bpctl_mod.c b/drivers/staging/silicom/bpctl_mod.c
[]
> @@ -44,9 +44,11 @@ MODULE_VERSION(BP_MOD_VER);
> spinlock_t bpvm_lock;
>
> #define lock_bpctl() \
> -if (down_interruptible(&bpctl_sema)) { \
> - return -ERESTARTSYS; \
> -} \
> +do { \
> + if (down_interruptible(&bpctl_sema)) { \
> + return -ERESTARTSYS; \
> + } \
> +} while (0)
Macros with goto or return are also poor style.
Probably better to expand these in-place instead.
next prev parent reply other threads:[~2013-06-17 16:35 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-17 16:26 [PATCH 1/4] silicom: checkpatch: assignments in if conditions Lorenz Haspel
2013-06-17 16:26 ` [PATCH 2/4] silicom: checkpatch: fixed whitespace errors Lorenz Haspel
2013-06-17 16:26 ` [PATCH 3/4] silicom: checkpatch: trailing statements Lorenz Haspel
2013-06-17 16:26 ` [PATCH 4/4] solicom: checkpatch: added parenthesis to macros Lorenz Haspel
2013-06-17 16:35 ` Joe Perches [this message]
2013-06-17 19:20 ` [PATCH 4/4 v2] silicom: checkpatch: errors caused by macros Lorenz Haspel
2013-06-17 19:42 ` Joe Perches
2013-06-17 20:49 ` Dan Carpenter
2013-06-17 21:03 ` Joe Perches
2013-06-17 21:14 ` Greg KH
2013-06-18 2:36 ` Joe Perches
2013-06-17 17:03 ` [PATCH 1/4] silicom: checkpatch: assignments in if conditions Dan Carpenter
[not found] ` <CAJ8yRxJf+B0Pgr9YWWeTbSfRZd21tF7H4j7sO-exvRXzsJYbvA@mail.gmail.com>
2013-06-17 17:25 ` Dan Carpenter
2013-06-17 17:22 ` Dan Carpenter
2013-06-17 17:34 ` Dan Carpenter
2013-06-17 17:42 ` Joe Perches
2013-06-17 19:15 ` [PATCH 1/4 v2] " Lorenz Haspel
2013-06-17 21:23 ` Dan Carpenter
2013-06-18 16:28 ` [PATCH 1/4 v3] " Lorenz Haspel
2013-06-18 18:32 ` Dan Carpenter
2013-06-18 18:32 ` Greg KH
2013-06-19 8:43 ` [PATCH 1/2 v2] silicom: checkpatch: errors caused by macros Lorenz Haspel
2013-06-19 8:44 ` [PATCH 2/2 v3] silicom: checkpatch: assignments in if conditions Lorenz Haspel
2013-06-24 23:14 ` Greg KH
2013-06-26 8:24 ` Lorenz Kernel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1371486921.2213.1.camel@joe-AO722 \
--to=joe@perches.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@i4.informatik.uni-erlangen.de \
--cc=linux-kernel@vger.kernel.org \
--cc=lorenz@badgers.com \
--cc=michael.banken@mathe.stud.uni-erlangen.de \
--cc=puff65537@bansheeslibrary.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®