mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Lorenz Haspel <lorenz@badgers.com>
To: devel@linuxdriverproject.org
Cc: gregkh@linuxfoundation.org, puff65537@bansheeslibrary.com,
	viro@zeniv.linux.org.uk,
	michael.banken@mathe.stud.uni-erlangen.de,
	dan.carpenter@oracle.com, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org,
	linux-kernel@i4.informatik.uni-erlangen.de, lorenz@badgers.com
Subject: [PATCH 4/4 v2] silicom: checkpatch: errors caused by macros
Date: Mon, 17 Jun 2013 21:20:14 +0200	[thread overview]
Message-ID: <1371496814-26104-1-git-send-email-lorenz@badgers.com> (raw)
In-Reply-To: <1371486386-8043-4-git-send-email-lorenz@badgers.com>

fixed checkpatch error:
added parenthesis around complex macro.

Macro with return was only used once in the code,
so I expandet it in-place.

Signed-off-by: Lorenz Haspel <lorenz@badgers.com>
Signed-off-by: Michael Banken <michael.banken@mathe.stud.uni-erlangen.de>
---
v2: expanded macro in-place
---
 drivers/staging/silicom/bpctl_mod.c |   11 ++++-------
 1 file changed, 4 insertions(+), 7 deletions(-)

diff --git a/drivers/staging/silicom/bpctl_mod.c b/drivers/staging/silicom/bpctl_mod.c
index 5511f5e..d2b8004 100644
--- a/drivers/staging/silicom/bpctl_mod.c
+++ b/drivers/staging/silicom/bpctl_mod.c
@@ -43,11 +43,6 @@ MODULE_DESCRIPTION(BP_MOD_DESCR);
 MODULE_VERSION(BP_MOD_VER);
 spinlock_t bpvm_lock;
 
-#define lock_bpctl()					\
-if (down_interruptible(&bpctl_sema)) {			\
-	return -ERESTARTSYS;				\
-}							\
-
 #define unlock_bpctl()					\
 	up(&bpctl_sema);
 
@@ -5452,7 +5447,8 @@ static long device_ioctl(struct file *file,	/* see include/linux/fs.h */
 	static bpctl_dev_t *pbpctl_dev;
 
 	/* lock_kernel(); */
-	lock_bpctl();
+	if (down_interruptible(&bpctl_sema))
+		return -ERESTARTSYS;
 	/* local_irq_save(flags); */
 	/* if(!spin_trylock_irqsave(&bpvm_lock)){
 	   local_irq_restore(flags);
@@ -7911,7 +7907,8 @@ int bypass_proc_create_dev_sd(bpctl_dev_t *pbp_device_block)
 	}
 	current_pfs->bypass_entry = procfs_dir;
 
-#define ENTRY(x) ret |= procfs_add(#x, &x##_ops, pbp_device_block)
+#define ENTRY(x) (ret |= procfs_add(#x, &x##_ops, pbp_device_block))
+
 	ENTRY(bypass_info);
 	if (pbp_device_block->bp_caps & SW_CTL_CAP) {
 		/* Create set param proc's */
-- 
1.7.10.4


  parent reply	other threads:[~2013-06-17 19:20 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-17 16:26 [PATCH 1/4] silicom: checkpatch: assignments in if conditions Lorenz Haspel
2013-06-17 16:26 ` [PATCH 2/4] silicom: checkpatch: fixed whitespace errors Lorenz Haspel
2013-06-17 16:26 ` [PATCH 3/4] silicom: checkpatch: trailing statements Lorenz Haspel
2013-06-17 16:26 ` [PATCH 4/4] solicom: checkpatch: added parenthesis to macros Lorenz Haspel
2013-06-17 16:35   ` Joe Perches
2013-06-17 19:20   ` Lorenz Haspel [this message]
2013-06-17 19:42     ` [PATCH 4/4 v2] silicom: checkpatch: errors caused by macros Joe Perches
2013-06-17 20:49       ` Dan Carpenter
2013-06-17 21:03         ` Joe Perches
2013-06-17 21:14           ` Greg KH
2013-06-18  2:36             ` Joe Perches
2013-06-17 17:03 ` [PATCH 1/4] silicom: checkpatch: assignments in if conditions Dan Carpenter
     [not found]   ` <CAJ8yRxJf+B0Pgr9YWWeTbSfRZd21tF7H4j7sO-exvRXzsJYbvA@mail.gmail.com>
2013-06-17 17:25     ` Dan Carpenter
2013-06-17 17:22 ` Dan Carpenter
2013-06-17 17:34   ` Dan Carpenter
2013-06-17 17:42   ` Joe Perches
2013-06-17 19:15 ` [PATCH 1/4 v2] " Lorenz Haspel
2013-06-17 21:23   ` Dan Carpenter
2013-06-18 16:28   ` [PATCH 1/4 v3] " Lorenz Haspel
2013-06-18 18:32     ` Dan Carpenter
2013-06-18 18:32     ` Greg KH
2013-06-19  8:43       ` [PATCH 1/2 v2] silicom: checkpatch: errors caused by macros Lorenz Haspel
2013-06-19  8:44       ` [PATCH 2/2 v3] silicom: checkpatch: assignments in if conditions Lorenz Haspel
2013-06-24 23:14         ` Greg KH
2013-06-26  8:24           ` Lorenz Kernel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1371496814-26104-1-git-send-email-lorenz@badgers.com \
    --to=lorenz@badgers.com \
    --cc=dan.carpenter@oracle.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=devel@linuxdriverproject.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@i4.informatik.uni-erlangen.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michael.banken@mathe.stud.uni-erlangen.de \
    --cc=puff65537@bansheeslibrary.com \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®