[PATCH] mfd: Convert comma to semicolon

[PATCH] mfd: Convert comma to semicolon

[Chen Ni]

Replace comma between expressions with semicolons.

Using a ',' in place of a ';' can have unintended side effects.
Although that is not the case here, it is seems best to use ';'
unless ',' is intended.

Found by inspection.
No functional change intended.
Compile tested only.

Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
---
 drivers/mfd/qnap-mcu.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/mfd/qnap-mcu.c b/drivers/mfd/qnap-mcu.c
index 4be39d8b2905..89a8a1913d42 100644
--- a/drivers/mfd/qnap-mcu.c
+++ b/drivers/mfd/qnap-mcu.c
@@ -158,9 +158,9 @@ int qnap_mcu_exec(struct qnap_mcu *mcu,
 
 	mutex_lock(&mcu->bus_lock);
 
-	reply->data = rx,
-	reply->length = length,
-	reply->received = 0,
+	reply->data = rx;
+	reply->length = length;
+	reply->received = 0;
 	reinit_completion(&reply->done);
 
 	qnap_mcu_write(mcu, cmd_data, cmd_data_size);
-- 
2.25.1

Re: [PATCH] mfd: Convert comma to semicolon

[Heiko Stübner]

Am Montag, 10. März 2025, 04:11:45 MEZ schrieb Chen Ni:
> Replace comma between expressions with semicolons.
> 
> Using a ',' in place of a ';' can have unintended side effects.
> Although that is not the case here, it is seems best to use ';'
> unless ',' is intended.

oh ... wonder how I could've messed that up.

And thanks a lot for finding this.

> Found by inspection.
> No functional change intended.
> Compile tested only.
> 

Fixes: 998f70d1806b ("mfd: Add base driver for qnap-mcu devices")

Reviewed-by: Heiko Stuebner <heiko@sntech.de>

> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
> ---
>  drivers/mfd/qnap-mcu.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/mfd/qnap-mcu.c b/drivers/mfd/qnap-mcu.c
> index 4be39d8b2905..89a8a1913d42 100644
> --- a/drivers/mfd/qnap-mcu.c
> +++ b/drivers/mfd/qnap-mcu.c
> @@ -158,9 +158,9 @@ int qnap_mcu_exec(struct qnap_mcu *mcu,
>  
>  	mutex_lock(&mcu->bus_lock);
>  
> -	reply->data = rx,
> -	reply->length = length,
> -	reply->received = 0,
> +	reply->data = rx;
> +	reply->length = length;
> +	reply->received = 0;
>  	reinit_completion(&reply->done);
>  
>  	qnap_mcu_write(mcu, cmd_data, cmd_data_size);
> 

Re: (subset) [PATCH] mfd: Convert comma to semicolon

[Lee Jones]

On Mon, 10 Mar 2025 11:11:45 +0800, Chen Ni wrote:
> Replace comma between expressions with semicolons.
> 
> Using a ',' in place of a ';' can have unintended side effects.
> Although that is not the case here, it is seems best to use ';'
> unless ',' is intended.
> 
> Found by inspection.
> No functional change intended.
> Compile tested only.
> 
> [...]

Applied, thanks!

[1/1] mfd: Convert comma to semicolon
      commit: f82718251e302fd6321224d6c3be969245d5a2d2

--
Lee Jones [李琼斯]