* [PATCH 5/5] mmc: omap_hsmmc: Add reg-offset to bindings documentation
@ 2013-06-26 1:25 Joel A Fernandes
2013-06-26 4:06 ` Hebbar, Gururaja
0 siblings, 1 reply; 2+ messages in thread
From: Joel A Fernandes @ 2013-06-26 1:25 UTC (permalink / raw)
To: Tony Lindgren, Sekhar Nori, Matt Porter, Grant Likely,
Rob Herring, Vinod Koul, Mark Brown, Benoit Cousson,
Russell King, Rob Landley, Andrew Morton, Jason Kridner,
Koen Kooi, Balaji TK, Chris Ball
Cc: Devicetree Discuss, Linux OMAP List, Linux ARM Kernel List,
Linux DaVinci Kernel List, Linux Kernel Mailing List,
Linux Documentation List, Linux MMC List, Linux SPI Devel List,
Arnd Bergmann
From: Joel A Fernandes <agnel.joel@gmail.com>
A new reg-offset property was added to account for register offsets
in some omap-hsmmc's. Document the new property.
Signed-off-by: Joel A Fernandes <agnel.joel@gmail.com>
---
.../devicetree/bindings/mmc/ti-omap-hsmmc.txt | 3 +++
1 file changed, 3 insertions(+)
diff --git a/Documentation/devicetree/bindings/mmc/ti-omap-hsmmc.txt b/Documentation/devicetree/bindings/mmc/ti-omap-hsmmc.txt
index 8c8908a..33f4b1e 100644
--- a/Documentation/devicetree/bindings/mmc/ti-omap-hsmmc.txt
+++ b/Documentation/devicetree/bindings/mmc/ti-omap-hsmmc.txt
@@ -20,6 +20,9 @@ ti,dual-volt: boolean, supports dual voltage cards
ti,non-removable: non-removable slot (like eMMC)
ti,needs-special-reset: Requires a special softreset sequence
ti,needs-special-hs-handling: HSMMC IP needs special setting for handling High Speed
+reg-offset: Supplementing the common reg property (described in bindings/mmc/mmc.txt),
+some omap-hsmmc's can start an offset from reg but are otherwise identical to others.
+The registers between start to offset are considered reserved.
dmas: List of DMA specifiers with the controller specific format
as described in the generic DMA client binding. A tx and rx
specifier is required.
--
1.7.9.5
^ permalink raw reply [flat|nested] 2+ messages in thread
* RE: [PATCH 5/5] mmc: omap_hsmmc: Add reg-offset to bindings documentation
2013-06-26 1:25 [PATCH 5/5] mmc: omap_hsmmc: Add reg-offset to bindings documentation Joel A Fernandes
@ 2013-06-26 4:06 ` Hebbar, Gururaja
0 siblings, 0 replies; 2+ messages in thread
From: Hebbar, Gururaja @ 2013-06-26 4:06 UTC (permalink / raw)
To: Fernandes, Joel, Tony Lindgren, Nori, Sekhar, Matt Porter,
Grant Likely, Rob Herring, Vinod Koul, Mark Brown, Cousson,
Benoit, Russell King, Rob Landley, Andrew Morton, Jason Kridner,
Koen Kooi, Krishnamoorthy, Balaji T, Chris Ball
Cc: Devicetree Discuss, Linux OMAP List, Linux ARM Kernel List,
Linux DaVinci Kernel List, Linux Kernel Mailing List,
Linux Documentation List, Linux MMC List, Linux SPI Devel List,
Arnd Bergmann
On Wed, Jun 26, 2013 at 06:55:01, Fernandes, Joel wrote:
> From: Joel A Fernandes <agnel.joel@gmail.com>
>
> A new reg-offset property was added to account for register offsets
> in some omap-hsmmc's. Document the new property.
>
Small nitpick
I usually get feedback that any driver DT changes and the associated
Binding doc update should come in one single patch for better readability.
In this case, I believe it would be patch 1/5 & 5/5
Regards,
Gururaja
> Signed-off-by: Joel A Fernandes <agnel.joel@gmail.com>
> ---
> .../devicetree/bindings/mmc/ti-omap-hsmmc.txt | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mmc/ti-omap-hsmmc.txt b/Documentation/devicetree/bindings/mmc/ti-omap-hsmmc.txt
> index 8c8908a..33f4b1e 100644
> --- a/Documentation/devicetree/bindings/mmc/ti-omap-hsmmc.txt
> +++ b/Documentation/devicetree/bindings/mmc/ti-omap-hsmmc.txt
> @@ -20,6 +20,9 @@ ti,dual-volt: boolean, supports dual voltage cards
> ti,non-removable: non-removable slot (like eMMC)
> ti,needs-special-reset: Requires a special softreset sequence
> ti,needs-special-hs-handling: HSMMC IP needs special setting for handling High Speed
> +reg-offset: Supplementing the common reg property (described in bindings/mmc/mmc.txt),
> +some omap-hsmmc's can start an offset from reg but are otherwise identical to others.
> +The registers between start to offset are considered reserved.
> dmas: List of DMA specifiers with the controller specific format
> as described in the generic DMA client binding. A tx and rx
> specifier is required.
> --
> 1.7.9.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-06-26 4:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-06-26 1:25 [PATCH 5/5] mmc: omap_hsmmc: Add reg-offset to bindings documentation Joel A Fernandes
2013-06-26 4:06 ` Hebbar, Gururaja
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®