From: Yadwinder Singh Brar <yadi.brar@samsung.com>
To: linux-kernel@vger.kernel.org
Cc: sbkim73@samsung.com, broonie@kernel.org, lgirdwood@gmail.com,
sameo@linux.intel.com, rob.herring@calxeda.com,
grant.likely@linaro.org, sachin.kamat@linaro.org,
yadi.brar01@gmail.com,
Yadwinder Singh Brar <yadi.brar@samsung.com>
Subject: [v2 PATCH 5/6] regulator: core: Remove redundant checks
Date: Sat, 29 Jun 2013 18:21:19 +0530 [thread overview]
Message-ID: <1372510280-31931-6-git-send-email-yadi.brar@samsung.com> (raw)
In-Reply-To: <1372510280-31931-1-git-send-email-yadi.brar@samsung.com>
In function _regulator_do_set_voltage(), old_selector gets intialised only
if (_regulator_is_enabled(rdev) && rdev->desc->ops->set_voltage_time_sel &&
rdev->desc->ops->get_voltage_sel)) is true.
Before calling set_voltage_time_sel() we checks if (old_selector >= 0) and it
will true if it got intialised properly. so we don't need to check again
_regulator_is_enabled(rdev) && rdev->desc->ops->set_voltage_time_sel before
calling set_voltage_time_sel().
Signed-off-by: Yadwinder Singh Brar <yadi.brar@samsung.com>
---
drivers/regulator/core.c | 5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
index 6e6371c..15368f3 100644
--- a/drivers/regulator/core.c
+++ b/drivers/regulator/core.c
@@ -2439,9 +2439,8 @@ static int _regulator_do_set_voltage(struct regulator_dev *rdev,
}
/* Call set_voltage_time_sel if successfully obtained old_selector */
- if (ret == 0 && !rdev->constraints->ramp_disable &&
- _regulator_is_enabled(rdev) && old_selector >= 0 &&
- old_selector != selector && rdev->desc->ops->set_voltage_time_sel) {
+ if (ret == 0 && !rdev->constraints->ramp_disable && old_selector >= 0
+ && old_selector != selector) {
delay = rdev->desc->ops->set_voltage_time_sel(rdev,
old_selector, selector);
--
1.7.0.4
next prev parent reply other threads:[~2013-07-08 13:00 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-29 12:51 [v2 PATCH 0/6] Add DT support for s2mps11 Yadwinder Singh Brar
2013-06-29 12:51 ` [v2 PATCH 1/6] regulator: core: Add support for disabling ramp delay Yadwinder Singh Brar
2013-07-08 13:19 ` Mark Brown
2013-06-29 12:51 ` [v2 PATCH 2/6] regulator: s2mps11: Implement set_ramp_rate callback for bucks Yadwinder Singh Brar
2013-07-08 13:26 ` Mark Brown
2013-06-29 12:51 ` [v2 PATCH 3/6] regulator: s2mps11: Add DT support Yadwinder Singh Brar
2013-06-29 12:51 ` [v2 PATCH 4/6] regulator: s2mps11: Convert driver completely to use set_ramp_delay callback Yadwinder Singh Brar
2013-06-29 12:51 ` Yadwinder Singh Brar [this message]
2013-07-08 13:21 ` [v2 PATCH 5/6] regulator: core: Remove redundant checks Mark Brown
2013-06-29 12:51 ` [v2 PATCH 6/6] mfd: s2mps11: Add device tree support Yadwinder Singh Brar
2013-07-08 13:28 ` Mark Brown
2013-07-08 13:41 ` Yadwinder Singh Brar
2013-07-11 11:06 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1372510280-31931-6-git-send-email-yadi.brar@samsung.com \
--to=yadi.brar@samsung.com \
--cc=broonie@kernel.org \
--cc=grant.likely@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rob.herring@calxeda.com \
--cc=sachin.kamat@linaro.org \
--cc=sameo@linux.intel.com \
--cc=sbkim73@samsung.com \
--cc=yadi.brar01@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®