mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: stefan.seyfried@googlemail.com
To: gregkh@linuxfoundation.org
Cc: linux-kernel@vger.kernel.org,
	Stefan Seyfried <seife+kernel@b1-systems.com>
Subject: [PATCH] 8250_pci: improve code comments and Kconfig help
Date: Mon,  1 Jul 2013 09:14:21 +0200	[thread overview]
Message-ID: <1372662861-11231-2-git-send-email-stefan.seyfried@googlemail.com> (raw)
In-Reply-To: <1372662861-11231-1-git-send-email-stefan.seyfried@googlemail.com>

From: Stefan Seyfried <seife+kernel@b1-systems.com>

The recent regression about NetMos 9835 Multi-I/O boards indicates
that comment pointing to the parport_serial driver could be helpful.

Signed-off-by: Stefan Seyfried <seife+kernel@b1-systems.com>
---
 drivers/tty/serial/8250/8250_pci.c | 6 ++++++
 drivers/tty/serial/8250/Kconfig    | 2 ++
 2 files changed, 8 insertions(+)

diff --git a/drivers/tty/serial/8250/8250_pci.c b/drivers/tty/serial/8250/8250_pci.c
index c52948b..c626c4f 100644
--- a/drivers/tty/serial/8250/8250_pci.c
+++ b/drivers/tty/serial/8250/8250_pci.c
@@ -4797,6 +4797,12 @@ static struct pci_device_id serial_pci_tbl[] = {
 		PCI_VENDOR_ID_IBM, 0x0299,
 		0, 0, pbn_b0_bt_2_115200 },
 
+	/*
+	 * other NetMos 9835 devices are most likely handled by the
+	 * parport_serial driver, check drivers/parport/parport_serial.c
+	 * before adding them here.
+	 */
+
 	{	PCI_VENDOR_ID_NETMOS, PCI_DEVICE_ID_NETMOS_9901,
 		0xA000, 0x1000,
 		0, 0, pbn_b0_1_115200 },
diff --git a/drivers/tty/serial/8250/Kconfig b/drivers/tty/serial/8250/Kconfig
index a1ba94d..f3b306e 100644
--- a/drivers/tty/serial/8250/Kconfig
+++ b/drivers/tty/serial/8250/Kconfig
@@ -116,6 +116,8 @@ config SERIAL_8250_PCI
 	  This builds standard PCI serial support. You may be able to
 	  disable this feature if you only need legacy serial support.
 	  Saves about 9K.
+	  Note that serial ports on NetMos 9835 Multi-I/O cards are handled
+	  by the parport_serial driver, enabled with CONFIG_PARPORT_SERIAL.
 
 config SERIAL_8250_HP300
 	tristate
-- 
1.8.3.1


      reply	other threads:[~2013-07-01  7:15 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-30 13:47 commit 8d2f8cd424 breaks parallel port, regression since 3.9-rc3 / backported to stable (3.4.37) Stefan Seyfried
2013-06-30 16:02 ` Greg Kroah-Hartman
2013-07-01  7:14   ` 8250_pci: improve code comments and Kconfig help stefan.seyfried
2013-07-01  7:14     ` stefan.seyfried [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1372662861-11231-2-git-send-email-stefan.seyfried@googlemail.com \
    --to=stefan.seyfried@googlemail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=seife+kernel@b1-systems.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®