Re: commit 8d2f8cd424 breaks parallel port, regression since 3.9-rc3 / backported to stable (3.4.37)

[Greg Kroah-Hartman <gregkh@linuxfoundation.org>]

On Sun, Jun 30, 2013 at 03:47:44PM +0200, Stefan Seyfried wrote:
> Hi all,
> 
> the following commit:
> 
> commit 8d2f8cd424ca0b99001f3ff4f5db87c4e525f366
> Author: Wang YanQing <udknight@gmail.com>
> Date:   Fri Mar 1 11:47:20 2013 +0800
> 
>     serial: 8250_pci: add support for another kind of NetMos Technology PCI 9835 Multi-I/O Controller
>     
>     01:08.0 Communication controller: NetMos Technology PCI 9835 Multi-I/O Controller (rev 01)
>         Subsystem: Device [1000:0012]
>         Control: I/O+ Mem+ BusMaster- SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B- DisINTx-
>         Status: Cap- 66MHz- UDF- FastB2B+ ParErr- DEVSEL=medium >TAbort- <TAbort- <MAbort- >SERR- <PERR- INTx-
>         Interrupt: pin A routed to IRQ 20
>         Region 0: I/O ports at e050 [size=8]
>         Region 1: I/O ports at e040 [size=8]
>         Region 2: I/O ports at e030 [size=8]
>         Region 3: I/O ports at e020 [size=8]
>         Region 4: I/O ports at e010 [size=8]
>         Region 5: I/O ports at e000 [size=16]
>     
>     Signed-off-by: Wang YanQing <udknight@gmail.com>
>     Cc: stable <stable@vger.kernel.org>
>     Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> 
> 
> breaks my
> 05:05.0 Communication controller: NetMos Technology PCI 9835 Multi-I/O Controller (rev 01)
> 05:05.0 0780: 9710:9835 (rev 01)
>         Subsystem: 1000:0012
> 
> which has two serial and one parallel port, driven by parport_serial.
> 
> The reason is, that this commit adds the PCI ID to 8250_pci, when it
> was handled by parport_serial before.
> In my case (openSUSE kernel), 8250 is built in and parport_serial is
> built as a module. Unfortunately with the device occupied by 8250,
> parport_serial finds no device and thus does not drive the parport.
> 
> I bisected this in the stable series after the openSUSE kernel update
> (which pulled in the stable kernel update) broke my printing.
> 
> Actually the above commit is totally unnecessary: the serial ports
> work very well without it, they are just driven by another driver.
> 
> Can this please be reverted? I can't see which problem it solves, but
> it definitely breaks the additional ports on my multi-i/o board.

Thanks for pointing this out, I missed the fact that parport_serial was
already controlling this device.  I'll revert it and get it into the
stable trees after it hits Linus's tree (probably next week some time.)

thanks,

greg k-h