* [PATCH] USB: EHCI: Fix resume signalling on remote wakeup
@ 2013-07-09 14:03 Roger Quadros
2013-07-09 15:24 ` Alan Stern
0 siblings, 1 reply; 2+ messages in thread
From: Roger Quadros @ 2013-07-09 14:03 UTC (permalink / raw)
To: gregkh, stern; +Cc: linux-usb, linux-kernel, Roger Quadros
Set the ehci->resuming flag for the port we receive a remote
wakeup on so that resume signalling can be completed.
Without this, the root hub timer will not fire again to check
if the resume was completed and there will be a never-ending wait on
on the port.
This effect is only observed if the HUB IRQ IN does not come after we
have initiated the port resume.
Signed-off-by: Roger Quadros <rogerq@ti.com>
---
drivers/usb/host/ehci-hub.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/usb/host/ehci-hub.c b/drivers/usb/host/ehci-hub.c
index 9ab4a4d..ca6289b 100644
--- a/drivers/usb/host/ehci-hub.c
+++ b/drivers/usb/host/ehci-hub.c
@@ -858,6 +858,7 @@ static int ehci_hub_control (
ehci->reset_done[wIndex] = jiffies
+ msecs_to_jiffies(20);
usb_hcd_start_port_resume(&hcd->self, wIndex);
+ set_bit(wIndex, &ehci->resuming_ports);
/* check the port again */
mod_timer(&ehci_to_hcd(ehci)->rh_timer,
ehci->reset_done[wIndex]);
--
1.7.4.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] USB: EHCI: Fix resume signalling on remote wakeup
2013-07-09 14:03 [PATCH] USB: EHCI: Fix resume signalling on remote wakeup Roger Quadros
@ 2013-07-09 15:24 ` Alan Stern
0 siblings, 0 replies; 2+ messages in thread
From: Alan Stern @ 2013-07-09 15:24 UTC (permalink / raw)
To: Roger Quadros; +Cc: gregkh, linux-usb, linux-kernel
On Tue, 9 Jul 2013, Roger Quadros wrote:
> Set the ehci->resuming flag for the port we receive a remote
> wakeup on so that resume signalling can be completed.
>
> Without this, the root hub timer will not fire again to check
> if the resume was completed and there will be a never-ending wait on
> on the port.
>
> This effect is only observed if the HUB IRQ IN does not come after we
> have initiated the port resume.
>
> Signed-off-by: Roger Quadros <rogerq@ti.com>
> ---
> drivers/usb/host/ehci-hub.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/usb/host/ehci-hub.c b/drivers/usb/host/ehci-hub.c
> index 9ab4a4d..ca6289b 100644
> --- a/drivers/usb/host/ehci-hub.c
> +++ b/drivers/usb/host/ehci-hub.c
> @@ -858,6 +858,7 @@ static int ehci_hub_control (
> ehci->reset_done[wIndex] = jiffies
> + msecs_to_jiffies(20);
> usb_hcd_start_port_resume(&hcd->self, wIndex);
> + set_bit(wIndex, &ehci->resuming_ports);
> /* check the port again */
> mod_timer(&ehci_to_hcd(ehci)->rh_timer,
> ehci->reset_done[wIndex]);
Acked-by: Alan Stern <stern@rowland.harvard.edu>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-07-09 15:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-07-09 14:03 [PATCH] USB: EHCI: Fix resume signalling on remote wakeup Roger Quadros
2013-07-09 15:24 ` Alan Stern
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®