From: Joe Perches <joe@perches.com>
To: Jean Delvare <jdelvare@suse.de>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
Ben Hutchings <ben@decadent.org.uk>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] firmware/dmi_scan: Drop OOM messages
Date: Wed, 10 Jul 2013 07:51:28 -0700 [thread overview]
Message-ID: <1373467888.14604.32.camel@joe-AO722> (raw)
In-Reply-To: <1373460424.4399.45.camel@chaos.site>
even more trivial...
On Wed, 2013-07-10 at 14:47 +0200, Jean Delvare wrote:
> +++ linux-3.11-rc0/drivers/firmware/dmi_scan.c 2013-07-10 14:11:56.544792703 +0200
> @@ -62,8 +62,6 @@ static const char * __init dmi_string(co
> str = dmi_alloc(len);
> if (str != NULL)
[]
> @@ -219,10 +217,8 @@ static void __init dmi_save_one_device(i
> dev = dmi_alloc(sizeof(*dev) + strlen(name) + 1);
> + if (!dev)
> return;
[]
> @@ -258,10 +254,8 @@ static void __init dmi_save_oem_strings_
> dev = dmi_alloc(sizeof(*dev));
> + if (!dev)
> break;
[]
> @@ -277,18 +271,14 @@ static void __init dmi_save_ipmi_device(
> data = dmi_alloc(dm->length);
> + if (data == NULL)
> return;
[]
> dev = dmi_alloc(sizeof(*dev));
> + if (!dev)
> return;
[]
> @@ -303,10 +293,9 @@ static void __init dmi_save_dev_onboard(
> onboard_dev = dmi_alloc(sizeof(*onboard_dev) + strlen(name) + 1);
> + if (!onboard_dev)
> return;
It'd also be nice to use the same test style
in all 6 uses.
if (!foo)
next parent reply other threads:[~2013-07-10 14:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1373460424.4399.45.camel@chaos.site>
2013-07-10 14:51 ` Joe Perches [this message]
2013-07-10 16:17 ` Jean Delvare
2013-07-10 17:36 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1373467888.14604.32.camel@joe-AO722 \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=ben@decadent.org.uk \
--cc=jdelvare@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®