From: Joe Perches <joe@perches.com>
To: Jean Delvare <jdelvare@suse.de>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
Ben Hutchings <ben@decadent.org.uk>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] firmware/dmi_scan: Drop OOM messages
Date: Wed, 10 Jul 2013 10:36:44 -0700 [thread overview]
Message-ID: <1373477804.14604.55.camel@joe-AO722> (raw)
In-Reply-To: <1373473051.4399.51.camel@chaos.site>
On Wed, 2013-07-10 at 18:17 +0200, Jean Delvare wrote:
> Le Wednesday 10 July 2013 à 07:51 -0700, Joe Perches a écrit :
> > even more trivial...
[]
> > It'd also be nice to use the same test style
> > in all 6 uses.
> >
> > if (!foo)
>
> Both styles are used throughout the file, and checkpatch doesn't
> complain.
And it might be wrong for checkpatch to complain as
there are tens of thousands of those in the kernel.
I think using both styles in the same file is poor
form though.
> Unifying the coding style is beyond the scope of my patchset,
> sorry. Feel free to send a patch on top of mine if you really care.
No worries. If I remember, I'll send a patch after
yours hit -next.
prev parent reply other threads:[~2013-07-10 17:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1373460424.4399.45.camel@chaos.site>
2013-07-10 14:51 ` Joe Perches
2013-07-10 16:17 ` Jean Delvare
2013-07-10 17:36 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1373477804.14604.55.camel@joe-AO722 \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=ben@decadent.org.uk \
--cc=jdelvare@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®