From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Alan Stern <stern@rowland.harvard.edu>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Felipe Balbi <balbi@ti.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
Geert Uytterhoeven <geert@linux-m68k.org>
Subject: [PATCH 6/6] [RFC] usb: gadget: USB_GADGET should depend on HAS_DMA
Date: Thu, 11 Jul 2013 15:54:05 +0200 [thread overview]
Message-ID: <1373550845-14457-6-git-send-email-geert@linux-m68k.org> (raw)
In-Reply-To: <1373550845-14457-1-git-send-email-geert@linux-m68k.org>
If NO_DMA=y:
drivers/built-in.o: In function `dma_set_coherent_mask':
include/linux/dma-mapping.h:93: undefined reference to `dma_supported'
include/linux/dma-mapping.h:93: undefined reference to `dma_supported'
drivers/built-in.o: In function `usb_gadget_unmap_request':
drivers/usb/gadget/udc-core.c:91: undefined reference to `dma_unmap_sg'
drivers/usb/gadget/udc-core.c:96: undefined reference to `dma_unmap_single'
drivers/built-in.o: In function `usb_gadget_map_request':
drivers/usb/gadget/udc-core.c:62: undefined reference to `dma_map_sg'
drivers/usb/gadget/udc-core.c:71: undefined reference to `dma_map_single'
drivers/usb/gadget/udc-core.c:74: undefined reference to `dma_mapping_error'
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
This one is very debatable: probably the parts using the DMA API should
be factored out, instead of disabling the whole USB gadget subsystem.
drivers/usb/gadget/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/gadget/Kconfig b/drivers/usb/gadget/Kconfig
index 3f8df56..a88fc47 100644
--- a/drivers/usb/gadget/Kconfig
+++ b/drivers/usb/gadget/Kconfig
@@ -15,6 +15,7 @@
menuconfig USB_GADGET
tristate "USB Gadget Support"
+ depends on HAS_DMA
select NLS
help
USB is a master/slave protocol, organized with one master
--
1.7.9.5
next prev parent reply other threads:[~2013-07-11 13:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-11 13:54 [PATCH 1/6] usb: dwc3: USB_DWC3 " Geert Uytterhoeven
2013-07-11 13:54 ` [PATCH 2/6] usb: chipidea: USB_CHIPIDEA_UDC " Geert Uytterhoeven
2013-07-11 13:54 ` [PATCH 3/6] usb: gadget: USB_MV_UDC " Geert Uytterhoeven
2013-07-11 13:54 ` [PATCH 4/6] usb: gadget: USB_FOTG210_UDC " Geert Uytterhoeven
2013-07-11 13:54 ` [PATCH 5/6] usb: gadget: USB_MV_U3D " Geert Uytterhoeven
2013-07-11 13:54 ` Geert Uytterhoeven [this message]
2013-07-11 15:51 ` [PATCH 6/6] [RFC] usb: gadget: USB_GADGET " Alan Stern
2013-07-12 7:21 ` Geert Uytterhoeven
2013-07-12 15:06 ` [PATCH] USB: GADGET: don't fail when DMA isn't present Alan Stern
2013-07-12 7:39 ` [PATCH 6/6] [RFC] usb: gadget: USB_GADGET should depend on HAS_DMA Alexander Shishkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1373550845-14457-6-git-send-email-geert@linux-m68k.org \
--to=geert@linux-m68k.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=arnd@arndb.de \
--cc=balbi@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®